Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stir 6 prep #858

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Stir 6 prep #858

merged 2 commits into from
Feb 7, 2024

Conversation

KrisThielemans
Copy link
Member

STIR 6.0 (will) put STIRConfig.cmake to lib/cmake/STIR-6.0. UCL/STIR#1358

Fixes #853

This PR might fail in DEVEL_BUILD=ON until the STIR PR is merged.

STIR 6.0 needs 1.3.4 for TOF
…R-V.v

We need to be able support pre-6.0 and 6.0 versions of STIR, so this makes it rather complicated.
@KrisThielemans KrisThielemans added this to the v3.6 milestone Feb 1, 2024
@KrisThielemans
Copy link
Member Author

I need to merge this soon, as STIR has moved on now. It works fine on my machines. GHA fails due to #857 which is unrelated.

@casperdcl if you could have a quick look, that'd be great. Otherwise I'll go ahead anyway...

@KrisThielemans
Copy link
Member Author

rerunning one job now happily get through building ROOT, i.e. #857 some to have auto-disappeared. Sadly, we now fail due to #861

@KrisThielemans KrisThielemans merged commit 236649a into SyneRBI:master Feb 7, 2024
10 of 12 checks passed
@KrisThielemans KrisThielemans deleted the STIR_6_prep branch February 7, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade parallelproj to 1.7.3
1 participant