Dev #749
Merged
Dev #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and_5p to be consistent with naming convention in ligate reducer (and be more unambiguous about what it means)
… match convention, and changed convention of order of strand parameters to `join_two_strands_with_substrands`
…well as added naming behavior for ligate/crossovers added behavior where names from a strand that has been nicked, has had a deleted crossover, or has had a deleted domain are inherited by the new strands. Also fixed naming when ligating two strands or adding a crossover strand between strands
…coding-warning-on-startup-#697 Fixes #697; fix JSON encoding warning on startup
…ifferent sequence to bound strand" checkbox when "assign complement to bound strands" is unchecked
…-warn-if-assigning-different-sequence-to-bound-strand-checkbox-when-assign-complement-to-bound-strands-is-unchecked closes #709; in DNA sequence assignment, disable "warn if assigning different sequence to bound strand" checkbox when "assign complement to bound strands" is unchecked
…nd fixed autofit behavior
…er-previously-chosen-M13-rotation-in-Assign-DNA-sequence-dialog closes #711: remember previously chosen M13 rotation in Assign DNA sequence dialog
…tate (#703) * Add and use svg_position to DesignMainHelicesProps * Remove usage of reassign_svg_position in reducers and Design constructor * Committing to save work in this branch * Remove usage of Helix.svg_position * Add back helix_group_change_reducer * Add some missing props * Add more missing props * Fix invert xy bug * Remove unused helix update * removed redundant toMap step before calling util.helices_assign_svg by changing parameter type of helices in that function * removed creation of redundant list in `helices_assign_svg` * changed all references to `invert_xy` or `invert_yz` to `invert_y` * fixed bug in calculating SVG positions when displaying only selected helices * fixed erroneous reference to DNAFileType * Update util.dart * add comments to helix_idx_to_svg_position_map memoized getter explaining the design decision * Remove Helix.invert_y See #703 (comment) * Add unit test for #703 (comment) * Set missing invert_y prop in ConnectedDesignMainArrows * Remove unneeded data structures and sorting in helices_assign_svg * commented out StopWatch print statements in helix_idx_to_svg_position_map getter Co-authored-by: David Doty <doty@ucdavis.edu>
…n why it is disabled if it is.
…vers to same type strands
…le for moving strands and domains
…domains-should-be-reselected-after-move #722 moving domain should be disallowed if overlapping another domain
…e-drawing-of-strands-when-connecting-a-crossover fixes #717: Disable drawing of strands when connecting a crossover
…aste-strands-breaks-when-helix-counts/indices-are-not-sufficient #732 fix bug where copy/paste strands breaks when helix counts/indices are not sufficient in destination design
* Update dependencies and Dart SDK in workflows * Fix template and remove deprecated function * Add pubspec.lock * Set minimum SDK version to 2.11 * Fix syntax error in workflow file * Name checkout actions to improve readability
…et domain on any helix, and fixed crash bug in setting this for helices with no domains
…-offset-uniform added option to set max offset of every helices based on largest-offset domain on any helix, and fixed crash bug in setting this for helices with no domains
* Create pull_request_template.md * Indicate to fill in automatic template in CONTRIBUTING.md
…-length-of-modification-connector- fixes #743: change length of modification "connector"
…menu of the View menu
…e-display-of-helices-in-main-view closes #746: disable display of helices in main view
…g-strands-should-keep-at-least-one-existing-name #681 merging strands should keep at least one existing name
… used length instead of 4
…t-in-View-menu #707 autofit in view menu
…on prompt for the user if they click "Reset local settings"
…ocal-settings-button-#719 closes #719: add "reset local settings" button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.