-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work In Progress: Update dependencies and Dart SDK in workflows #730
Conversation
DescriptionUpdated dependencies in response to OverReact upgrade to version 4.2.6. scadnano workflows will now use Dart SDK 2.13 instead of 2.9 because Dart SDK 2.9 is no longer supported by OverReact. Dart SDK 2.13 is the newest SDK supported by OverReact because newer versions rely on analyzer 1.x, which OverReact does not support as noted in the OverReact workflow file. react_components_test_template.html has been updated in response to upgrading test_html_builder from version 1 to version 2. Lastly, to ensure that our developers are working on the app with the exact same versions, I committed the pubspec.lock file. This is recommended for application packages, as noted in the Dart documentation. Related IssueHow Has This Been Tested?
|
Do you think we should change this line: environment:
sdk: '>=2.9.0 <3.0.0' to environment:
sdk: '>=2.11.0 <3.0.0' Since OverReact is going to require |
I am able to rub locally after running
then
Unit tests (running It's annoying that we still get the analyzer warning: But it appears that OverReact is still requiring the old version of analyzer: |
@dave-doty Updated SDK requirement in pubspec.yaml and fixed and tested the Github workflows, as indicated above. Ready to merge as soon as changes are approved. |
Testing Dart CI workflow by triggering it through this pull request