-
-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install / build fails for node > 10.1 #994
Comments
build fails on macOS for node > 10.1 Here's the build output with node 10.3.0
|
@ellogwen please edit the issue title to - |
@ellogwen Thanks, that was quick! |
@ashishpandey001 notifications are a nice feature ^^ |
@darkguy2008 Simply install nvm and use node 10.1.0, your builds will succeed then. |
@ashishpandey001 NVM is not the solution. I actually had uninstalled it because it throws warnings as Node 10 comes with an old NPM version and when you try to update it, it doesn't work, NVM for Windows hasn't been updated in ages and the workaround in their issues feed is not ideal either. The correct solution would be to fix this instead. I had to downgrade to 8.11 for it to work but then I have to reinstall Node versions every time I switch to another project... what a nuisance. |
@darkguy2008 Well, until this is fixed, nvm could've helped. But, that's upto you. |
@darkguy2008 It's possible to run multiple node versions on a per project basis, without nvm thanks to the node npm package. To just run basic things on the command line, you'll need to use npx: $ npx node@10.1.0 ./index.js But, since it's an npm module, you can {
"name": "node-version-test",
"version": "1.0.0",
"description": "",
"main": "server.js",
"scripts": {
"start": "node server.js",
},
"author": "",
"license": "WTFPL",
"devDependencies": {
"node": "^10.1.0"
}
} [ccase:dante] ~/d/t/node-version-test > # We can see that this runs node v10.1.0:
[ccase:dante] ~/d/t/node-version-test > npm start
> pkg-version-test@1.0.0 start /Users/ccase/devel/test/node-pkg-version-test
> node server.js
Versions:
{ http_parser: '2.8.0',
node: '10.1.0',
v8: '6.6.346.27-node.6',
uv: '1.20.2',
zlib: '1.2.11',
ares: '1.14.0',
modules: '64',
nghttp2: '1.29.0',
napi: '3',
openssl: '1.1.0h',
icu: '61.1',
unicode: '10.0',
cldr: '33.0',
tz: '2018c' }
[ccase:dante] ~/d/t/node-version-test > # But, my local node is older:
[ccase:dante] ~/d/t/node-version-test > node server.js
Versions:
{ http_parser: '2.8.0',
node: '9.10.1',
v8: '6.2.414.46-node.23',
uv: '1.19.2',
zlib: '1.2.11',
ares: '1.13.0',
modules: '59',
nghttp2: '1.29.0',
napi: '2',
openssl: '1.0.2o',
icu: '61.1',
unicode: '10.0',
cldr: '33.0',
tz: '2018c' }
[ccase:dante] ~/d/t/node-version-test > IMHO this trick is a more elegant solution than NVM, since you can handle problems like this one on a per project basis, without too much overhead. And if everything runs inside an npm script, then other contributors don't have to have headaches about having the right version installed. DisclaimerI've used these tricks before on macOS and Linux, but didn't have a windows box handy to try this on. The |
The v4.0.1 release now supports node v10: https://github.com/mapbox/node-sqlite3/blob/master/CHANGELOG.md#401 |
Relate-to: TryGhost/node-sqlite3#994 Change-Id: I367442888290f6f127beb6c174b47077ed728a48 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Are you sure it is fixed ? I am still observing
v10.8.0 on arm32v7/debian I can share docker container to reproduce. |
Yep, also happening to me on Arch with node 10.8.0. The What allowed me to install sqlite3 was After that, I still couldn't run my app (Beaker Browser), as I got
But I don't think it is sqlite3 related at that point, so I'll continue this there |
Same:
The main error I believe occurs here:
Full build output
I can also confirm the same command succeeds with |
@armarti @ Xananax '~/resources/beaker/source/node_modules/sqlite3/lib/binding/electron-v1.7-linux-x64/node_sqlite3.node' |
For the record: 4.0.1 added Node v10 support https://github.com/mapbox/node-sqlite3/blob/master/CHANGELOG.md#401 As suggested elsewhere it would help to have this module version packaged in debian Anyway I'll keep an eye on it and will update this doc: |
I could install the package with a node 10.1 in linux.
With node 10.2 node-pre-gyp fails with
missing file core.h
The text was updated successfully, but these errors were encountered: