Remove featured, tag, author & role API params #6005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErisDS
force-pushed
the
old-filter-clean
branch
from
de1427f to
0bb0416
Compare
ErisDS
force-pushed
the
old-filter-clean
branch
from
0bb0416 to
b8a3415
Compare
refs TryGhost#5943 - removed featured, tag and author parameters from posts API - featured was only used in tests - removed role filter from users API - role was only used in tests - fixed up the tests, skipping those that don't quite work yet
sebgie
added a commit
that referenced
this pull request
Oct 27, 2015
Remove featured, tag, author & role API params
kevinansfield
added a commit
to kevinansfield/Ghost
that referenced
this pull request
Oct 27, 2015
refs TryGhost#6005 - updates use of the query params removed in TryGhost#6005 to use new `filter` param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
featured,tagandauthorparams from the Posts APIroleparam from the Users APIThe featured and role params were only ever used in tests as far as I am aware.
The tag and author params were used by the frontend controller and rss generator, which are switched over in #6000 and #6004.
The new
filterparameter implementation does not yet support arolefilter on users, this can be re-added if and when it is needed. The new implementation also does not yet properly validate invalid tags / authors - this was recently added to the old style parameters, and should be reimplemented.The @todos in this PR need to be broken out into issues so we don't lose track of them, but none of them are strictly required for an initial version of the public API tools.
refs #5943