Switch RSS to use new filter param #6004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost#5943, TryGhost#5091 - split out channel config - use config.theme instead of api calls to grab title & desc - wrap rss call in a function which sets channel config for RSS feeds - change rss `getData` function to use the new multiple-query-handling fetchData functionality - make sure channelConfig is set in all tests
sebgie
added a commit
that referenced
this pull request
Oct 27, 2015
Switch RSS to use new filter param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #6000. #6000 updates the frontend controllers to handle multiple queries and provides handling & formatting tools for the data that is returned.
This PR builds on this, splitting out the channel config, reducing the number of API queries needed, and then updating the RSS feed generation to be built on top of this new multiple-query handling.
All of this is slowly working towards making dynamic channels work (#5091) but in this case, this PR does the absolute bare-minimum of reworking to get RSS working again. This means there is some code and concept duplication which can and will be reworked at a later date.
This PR allows us to remove the old-style filtering so that we can do our first Public API release without those parameters being available.
refs #5943, #5091
getDatafunction to use the new multiple-query-handling fetchData functionality