Helper refactor & fixes #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated navigation and pagination helpers to use SafeString - nav and pagination don't need triple taches any more - nav tests updated, and renamed to match helper name
- fixed a bug whereby once you visit the homepage the homepage menu item is always marked as the active page - this was due to passing the config object being done by reference rather than by value, and therefore setting the selected item was persisted.
- moved template logic out of individual helpers and into Ghost - simplified template-driven helpers into closures which maintain the context of handlebars - with handlebars context we have access to data, so don't need to pass data in - check data to test that it is a simple object and not a function - moved helpers back into index.js - provided tests for both template functions in ghost and the nav helper so we are back to where we were
morficus
pushed a commit
to morficus/Ghost
that referenced
this pull request
Sep 4, 2014
Helper refactor & fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #246 items 1,2 and 5
Also fixes a bug with the nav helper persisting the active item
Thought I'd put this up as a PR and see if anyone has any feedback before I merge it tomorrow