-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme API: Helpers, naming and API friendliness #246
Comments
ghost
assigned ErisDS
Jul 9, 2013
I have 1, 2 and 5 done in a branch |
ErisDS
added a commit
to ErisDS/Ghost
that referenced
this issue
Jul 11, 2013
- updated navigation and pagination helpers to use SafeString - nav and pagination don't need triple taches any more - nav tests updated, and renamed to match helper name
ErisDS
added a commit
to ErisDS/Ghost
that referenced
this issue
Jul 11, 2013
- moved template logic out of individual helpers and into Ghost - simplified template-driven helpers into closures which maintain the context of handlebars - with handlebars context we have access to data, so don't need to pass data in - check data to test that it is a simple object and not a function - moved helpers back into index.js - provided tests for both template functions in ghost and the nav helper so we are back to where we were
This was referenced Jul 11, 2013
Merged
This was referenced Jul 14, 2013
Closed
No more of this needs looking at right now, punting to 0.4 |
halfdan
added a commit
to halfdan/Ghost
that referenced
this issue
Oct 17, 2013
All looks done to me - at least in the context of September 2013. Suggest close and move future work to new issues |
Agreed, there are things left to do but we're significantly further forward than we are and this issue doesn't really make sense anymore. |
morficus
pushed a commit
to morficus/Ghost
that referenced
this issue
Sep 4, 2014
- updated navigation and pagination helpers to use SafeString - nav and pagination don't need triple taches any more - nav tests updated, and renamed to match helper name
morficus
pushed a commit
to morficus/Ghost
that referenced
this issue
Sep 4, 2014
- moved template logic out of individual helpers and into Ghost - simplified template-driven helpers into closures which maintain the context of handlebars - with handlebars context we have access to data, so don't need to pass data in - check data to test that it is a simple object and not a function - moved helpers back into index.js - provided tests for both template functions in ghost and the nav helper so we are back to where we were
morficus
pushed a commit
to morficus/Ghost
that referenced
this issue
Sep 4, 2014
- renamed single.hbs to post.hbs - casper updated to match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As it stands there are a few inconsistencies and oddities with the set of core helpers that we have on offer:
{{
and some require triple{{{
- triple taches are used to indicate that the content should not be escaped, but for helpers which always render HTML, the non-escaping should be managed with handlebars.SafeString()content
should be comecontent_raw
andcontent_html
should becomecontent
- big breaking change alert! - to be done in 0.2: Theme API: Rename content fields #253single.hbs
- should bepost.hbs
(Ghost + Casper)Example for 7. is on it's way
This is a big-arse issue I'm using for keeping track of Theme API related stuff, expect to see sub issues in the near future.
The text was updated successfully, but these errors were encountered: