Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated helper pageUrl #2217

Closed
ErisDS opened this issue Feb 18, 2014 · 5 comments · Fixed by #7509
Closed

Remove the deprecated helper pageUrl #2217

ErisDS opened this issue Feb 18, 2014 · 5 comments · Fixed by #7509
Milestone
1.0.0-alpha.4

Comments

@ErisDS
Copy link
Member

ErisDS commented Feb 18, 2014

In #2216 pageUrl is being renamed to page_url, but the original name is being left in as an alias with a deprecated warning message.

We've left that in for a Ghost version to give theme developers time to update their themes, after #2216 is complete, and we have shipped 0.5, we need to clean up after ourselves and remove the deprecated pageUrl alias.
@ErisDS ErisDS added this to the 0.6 milestone Feb 18, 2014
@ErisDS ErisDS added the themes label Feb 18, 2014
@ErisDS ErisDS mentioned this issue Feb 18, 2014
Closed
@knunery
Copy link
Contributor

knunery commented Feb 19, 2014

I'll take this one.

@ErisDS
Copy link
Member Author

ErisDS commented Feb 19, 2014

Hi @knunery thanks for jumping in 👍 This issue has been raised to keep track of this helper so that we remember to remove it in future - it needs to be done after we ship Ghost version 0.5.

However, the issue to rename and deprecate the helper #2216 is still looking for someone to do it if you're interested?

Sorry for the confusion 😦

@ErisDS ErisDS modified the milestones: 0.5, 0.6 Mar 24, 2014
@ErisDS ErisDS modified the milestones: 0.6, 0.5 Apr 7, 2014
@ErisDS ErisDS modified the milestones: 0.6 Apps, 0.5 Multi-user May 29, 2014
rohan013 pushed a commit to rohan013/Ghost that referenced this issue Aug 11, 2014
Remove deprecated helper PageUrl
3e5ab65 
Fixes TryGhost#2217
@rohan013 rohan013 mentioned this issue Aug 11, 2014
Closed
@ErisDS ErisDS modified the milestones: 0.6 Apps, Future Backlog Sep 2, 2014
@jonwgeorge
Copy link

@ErisDS I see one PR, but it looks like there are more references to PateUrl in the Ghost core, does this still need to be tackled?

@ErisDS
Copy link
Member Author

ErisDS commented May 28, 2015

Not for a while yet.

@ErisDS ErisDS removed the good first issue [triage] Start here if you've never contributed before. label Jun 2, 2015
@ErisDS ErisDS modified the milestone: Future Backlog Oct 13, 2015
ErisDS added a commit to ErisDS/Ghost that referenced this issue Oct 6, 2016
@ErisDS
🔥 Remove deprecated pageUrl helper
a0c6d7b 
closes TryGhost#2217

- This helper has been deprecated in favour of `page_url` for more than 2 years!!!
- Ghost 1.0.0 is the end of all of this 💩
@ErisDS ErisDS mentioned this issue Oct 6, 2016
Merged
@ErisDS ErisDS added this to the 1.0.0-alpha.4 milestone Oct 6, 2016
@ErisDS
Copy link
Member Author

ErisDS commented Oct 6, 2016

This should be finally removed in 1.0.0

kirrg001 pushed a commit that referenced this issue Oct 6, 2016
@ErisDS @kirrg001
🔥 Remove deprecated pageUrl helper (#7509)
a98efe1 
closes #2217

- This helper has been deprecated in favour of `page_url` for more than 2 years!!!
- Ghost 1.0.0 is the end of all of this 💩
mixonic pushed a commit to mixonic/Ghost that referenced this issue Oct 28, 2016
@ErisDS @mixonic
🔥 Remove deprecated pageUrl helper (TryGhost#7509)
d532906 
closes TryGhost#2217

- This helper has been deprecated in favour of `page_url` for more than 2 years!!!
- Ghost 1.0.0 is the end of all of this 💩
geekhuyang pushed a commit to geekhuyang/Ghost that referenced this issue Nov 20, 2016
@ErisDS @geekhuyang
🔥 Remove deprecated pageUrl helper (TryGhost#7509)
8188a21 
closes TryGhost#2217

- This helper has been deprecated in favour of `page_url` for more than 2 years!!!
- Ghost 1.0.0 is the end of all of this 💩
tigefa4u pushed a commit to tigefa4u/Ghost that referenced this issue Aug 3, 2022
@renovate
Update dependency ember-moment to v10 (TryGhost#2217)
864fe78 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@mdno mdno mentioned this issue Jan 9, 2023
Open
@snyk-bot snyk-bot mentioned this issue Jan 9, 2023
Open
@fooiskandar fooiskandar mentioned this issue Jan 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-alpha.4
3 participants
@knunery @ErisDS @jonwgeorge