New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update title and image from a script #418

Merged

Toxblh merged 1 commit into Toxblh:master from ash14:json-script-output

Sep 16, 2021

Contributor

ash14 commented Sep 16, 2021

If a script returns a valid JSON string, its title and image values are used to update (or unset) the button's title and image respectively.
If the returned string cannot be parsed as a JSON object its used as the title string, keeping compatibility with existing scripts.

This resolves issues like #268

README needs updating and needs some tests but would appreciate some review / feedback before continuing.

Thanks!


          Parse title/image from a script's output

117cf11

Toxblh merged commit 352bf48 into Toxblh:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet