Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct tiledb_query_get_range_var call #662

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

eddelbuettel
Copy link
Contributor

This small PR corrects a minor yet subtle copy-and-paste-and-forgot-to-edit error uncovered by a new code parsing tool from @dmurdoch which @kurthornik ran at CRAN and kindly emailed me about. The (R-level) accessor for the API query function for a variable length (i.e., string) buffer was only copied over from the fixed size and lacked the trailing four characters _var resulting in a twice-defined function where one shadows the other. Nice tricks one can play when computing on the language, and well spotted!

Minimal change made, documentation header altered, resulting changes also affect NAMESPACE as they should and Rd files. Small (and hitherto missing) test section added as well.

Copy link

This pull request has been linked to Shortcut Story #41552: Correct tiledb_query_get_range for variable length case.

@eddelbuettel
Copy link
Contributor Author

For completeness:

image

Copy link
Member

@aaronwolen aaronwolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice catch.

@eddelbuettel eddelbuettel merged commit e7cf0e5 into master Feb 22, 2024
1 check passed
@eddelbuettel eddelbuettel deleted the de/sc-41552/correct_tiledb_query_get_range branch February 22, 2024 17:34
@eddelbuettel eddelbuettel mentioned this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants