Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audiotags2 -> Audiotags #18

Merged
merged 16 commits into from
Jul 31, 2022
Merged

Audiotags2 -> Audiotags #18

merged 16 commits into from
Jul 31, 2022

Conversation

pinkforest
Copy link
Collaborator

  • Merging back fork
  • TBD: Have to revert some commits

martpie and others added 12 commits May 25, 2022 16:17
@martpie
Upgrade id3 from 0.5.1 to 1.0.3
5faa2dc
@martpie
Upgrade mp4ameta from 0.6 to 0.11
03b9736
@martpie
Copy test files to tmp directory before running tests
b1995bd
@martpie
Run GitHub actions on all PR
4fa5a66
@martpie @RodolpheThienard
Import @RodolpheThienard's duration (#4)
66d8994 
* give back the duration for mp4 and mp3

* calcul duration for flac

* adding set_duration

* fix duration for all extension

* Remove set_duration + reset test data

Co-authored-by: RodolpheThienard <thienard.rodolphe1@gmail.Com>
@martpie @Dalvany
Import @Dalvany's genre (#5)
edae1dc 
* Add genre

Add genre tag

* Add some tests

Co-authored-by: Dalvany <9901407+Dalvany@users.noreply.github.com>
@martpie
Merge pull request #3 from martpie/next
04a5f71 
Next
@martpie
Establish fork (#6)
1276b3a 
* Adapt Cargo + License + Changelog

* Update GitHub actions to use actions-rs

* Fix formatting

* Fix clippy

* Re-fix formatting

* Adapt README.md

* Rename crate, update README.md

* Fix cargo test

* Fix clippy (again)

* Docs improvements

* Remove deprecated function
@martpie
Remove old documentation
e7a0eeb
@martpie
0.3.1
16ef6fb
@pinkforest
Merge pull request #17 from martpie/main
46caf6c 
Merge from audiotags2 fork
@pinkforest
Re-merged Cargo.toml for 0.4.0
0a65794
@martpie
Copy link
Contributor

martpie commented Jul 31, 2022

👀

@pinkforest
Copy link
Collaborator Author

@martpie can you have a look how the changes look pls? :) 🦄

martpie
martpie approved these changes Jul 31, 2022
View reviewed changes
Copy link
Contributor

@martpie martpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo not passing CI, happy to see the project live on!

LICENSE
@@ -1,5 +1,6 @@
MIT License

Copyright (c) 2020 Tianyi Shi
Copyright (c) 2022 Pierre de la Martinière
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to remove me, that's all fine

Copy link
Collaborator Author

@pinkforest pinkforest Jul 31, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a merge party :)

@pinkforest pinkforest changed the title WIP: Audiotags2 -> Audiotags Audiotags2 -> Audiotags Jul 31, 2022
@pinkforest pinkforest merged commit 039f2f4 into main Jul 31, 2022
This was referenced Jul 31, 2022
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martpie martpie martpie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinkforest @martpie