-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: support for X/Y style TRACKNUMBER #5
Comments
This fixes TianyiShi2001#5 Example FLAC metadata using this style: comment[0]: album=Chosen Lords comment[1]: discid=820d4b0a comment[2]: title=Reunion 2 comment[3]: artist=Aphex Twin comment[4]: tracknumber=2/10
* Upgrade id3 from 0.5.1 to 1.0.3 * Upgrade mp4ameta from 0.6 to 0.11 * Copy test files to tmp directory before running tests * Run GitHub actions on all PR * Import @RodolpheThienard's duration (#4) * give back the duration for mp4 and mp3 * calcul duration for flac * adding set_duration * fix duration for all extension * Remove set_duration + reset test data Co-authored-by: RodolpheThienard <thienard.rodolphe1@gmail.Com> * Import @Dalvany's genre (#5) * Add genre Add genre tag * Add some tests Co-authored-by: Dalvany <9901407+Dalvany@users.noreply.github.com> * Establish fork (#6) * Adapt Cargo + License + Changelog * Update GitHub actions to use actions-rs * Fix formatting * Fix clippy * Re-fix formatting * Adapt README.md * Rename crate, update README.md * Fix cargo test * Fix clippy (again) * Docs improvements * Remove deprecated function * Remove old documentation * 0.3.1 * Re-merged Cargo.toml for 0.4.0 * Re-merged License * Re-merge README.md * Re-merge lib.rs tests * Happy clippy is the best clippy Co-authored-by: Pierre de la Martinière <pierre.de.la.martiniere@gmail.com> Co-authored-by: RodolpheThienard <thienard.rodolphe1@gmail.Com> Co-authored-by: Dalvany <9901407+Dalvany@users.noreply.github.com>
I know this is an older issue, but I wanted to chime in on this. It's definitely not an uncommon use-case. ototoy, for example, tags all their flacs with the The vorbis comment spec does not specify that any of the fields need to be in a specific format, or that It might be complicated to change the return type of |
I have FLAC files which look like this:
audiotags's call to track_number() returns None in this case. I would prefer if it returnes Some(2).
My understanding is that this use of TRACKNUMBER may be non-standard but it's not uncommon. A number of other tools (easytags, for example) work successfully with files like this.
The text was updated successfully, but these errors were encountered: