Test(Component Date Editor) #4890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Addition of a new parameter to solve the problem of the date editor component for forms whose .header-image is not visible by adding a new component - Use bhDateEdit in Off Days E2E test closes Third-Culture-Software#4889
jeremielodi
approved these changes
Sep 8, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 8, 2020
4890: Test(Component Date Editor) r=jeremielodi a=lomamech - Addition of a new parameter to solve the problem of the date editor component for forms whose .header-image is not visible by adding a new component - Use bhDateEdit in Off Days E2E test closes #4889 Co-authored-by: Chris Lomame <lomamech@gmail.com>
|
Build failed: |
|
bors try |
tryBuild failed: |
|
bors try |
|
Oh! Can this PR be closed then? |
|
Not yet, I just arranged the dateEditor ent-to-end test bug |
tryBuild succeeded: |
|
@jniles you can merge if the bors passes successfully |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
component for forms whose .header-image is not visible by adding a new
component
closes #4889