Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problematic for the E2E test of the bh-date-editor component #4889

Closed
lomamech opened this issue Sep 4, 2020 · 0 comments · Fixed by #4890
Closed

Problematic for the E2E test of the bh-date-editor component #4889

lomamech opened this issue Sep 4, 2020 · 0 comments · Fixed by #4890
Assignees
Labels

Comments

@lomamech
Copy link
Collaborator

lomamech commented Sep 4, 2020

There is a problem for when we try to write the E2E test using the bh-date-editor component, indeed if we analyze the code that allows testing on the component, we realize that 'there is a click on the .header-image element, while this element is not visible when using the component in a modal window

@lomamech lomamech self-assigned this Sep 4, 2020
@lomamech lomamech added the Bug label Sep 4, 2020
bors bot added a commit that referenced this issue Sep 8, 2020
4890: Test(Component Date Editor) r=jeremielodi a=lomamech

- Addition of a new parameter to solve the problem of the date editor
component for forms whose .header-image is not visible by adding a new
component
- Use bhDateEdit in Off Days E2E test

closes #4889

Co-authored-by: Chris Lomame <lomamech@gmail.com>
bors bot added a commit that referenced this issue Sep 9, 2020
4890: Test(Component Date Editor) r=jniles a=lomamech

- Addition of a new parameter to solve the problem of the date editor
component for forms whose .header-image is not visible by adding a new
component
- Use bhDateEdit in Off Days E2E test

closes #4889

Co-authored-by: Chris Lomame <lomamech@gmail.com>
@bors bors bot closed this as completed in 262a052 Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant