Added checks to the path in installer (setup.py) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have added the code on the setup.py file for checking if paths are all valid documents variable and gameFolder variable and also make the functionality to ask the user for entering the path again if its not valid.
ThiaudioTT
requested changes
May 20, 2023
There was a problem hiding this comment.
Thank you for opening the PR!
But, your commits doesn't close the issue.
We indeed check if the path is valid, but also check if the game is present in that folder. Checking if the path is valid we already do through exceptions. I will write this explicitly in #13.
| @@ -27,6 +27,13 @@ | |||
|
|
|||
| # 1 | |||
| documents = os.environ['USERPROFILE'] + "\\Documents\\Paradox Interactive\\Hearts of Iron IV" | |||
|
|
|||
| if(os.path.exists(documents)): | |||
There was a problem hiding this comment.
We already do this as an Exception. See line 42
| @@ -69,6 +76,13 @@ | |||
|
|
|||
| # 3 | |||
| gameFolder = os.environ['PROGRAMFILES(X86)'] + "\\Steam\\steamapps\\common\\Hearts of Iron IV" | |||
|
|
|||
| if(os.path.exists(gameFolder)): | |||
There was a problem hiding this comment.
We already do this, see line 91
|
Closing... Feel free to open another PR anytime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the code on the setup.py file for checking if paths are all valid documents variable and gameFolder variable and also make the functionality to ask the user for entering the path again if its not valid.