Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the paths in installer are all valid #13

Closed
ThiaudioTT opened this issue May 20, 2023 · 2 comments · Fixed by #16
Closed

Check if the paths in installer are all valid #13

ThiaudioTT opened this issue May 20, 2023 · 2 comments · Fixed by #16
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ThiaudioTT
Copy link
Owner

ThiaudioTT commented May 20, 2023

Add checking if paths in installer are all valids.

If it isn't valid, ask the user to enter the path again.

image

Obs:
Checking if the path is valid isn't enough, we already do it. Check if the path contains the game and the others resources that the presence uses (if any) and asks the user until we find a real valid path.

@ThiaudioTT ThiaudioTT added enhancement New feature or request good first issue Good for newcomers labels May 20, 2023
@ThiaudioTT ThiaudioTT changed the title Check if the paths ins installer are all valid Check if the paths in installer are all valid May 20, 2023
@kiozet
Copy link

kiozet commented May 20, 2023

Hey, buddy! If you haven't solved the problem yet, please assigne it to me!

@ThiaudioTT
Copy link
Owner Author

Hey, buddy! If you haven't solved the problem yet, please assigne it to me!

Hi! Thank you so much!

It appears that is already a pull request on, but it doesn't solve the problem. Feel free to open another or work on the same PR.

@ThiaudioTT ThiaudioTT linked a pull request May 20, 2023 that will close this issue
@kiozet kiozet removed their assignment May 23, 2023
@ThiaudioTT ThiaudioTT linked a pull request May 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
2 participants