[Android] App crash when unmounting video #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattvot
pushed a commit
to calvium/react-native-video
that referenced
this pull request
May 12, 2017
* master: Added flag for background mode (TheWidlarzGroup#563) issue 310 - Added a new property, ignoreSilentSwitch. (TheWidlarzGroup#403) Add progressUpdateInterval to android-exoplayer (TheWidlarzGroup#540) Initial WPF Support (TheWidlarzGroup#385) added progressUpdateInterval to Android (TheWidlarzGroup#512) load new source if it is different (TheWidlarzGroup#502) Pausing progress if it was playing and the stating again (TheWidlarzGroup#526) bump android dependencies (TheWidlarzGroup#524) Update ExoPlayer to r2.2.0 (TheWidlarzGroup#505) Update readme (TheWidlarzGroup#497) [Android] App crash when unmounting video (TheWidlarzGroup#533) Fix/494 (TheWidlarzGroup#537) fix(RCTVideo.m): Fixed status bar disappearing issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #492.
The problem is that
ScalableVideoViewandReactVideoViewwere callingmMediaPlayer.release()on unmount, but were not resettingmMediaPlayer = null. The next time around (e.g. whenisPlaying()is called),mMediaPlayeris in an invalid (released) state, but the null-checks do not get hit (becausemMediaPlayer != null), which causes an exception to be thrown.The issue has since been fixed in the
release()method ofScalableVideoView(version 1.0.4). So I've bumped up the dependencies inbuild.gradleto use that. I've also changedcleanupMediaPlayerResourcesinReactVideoViewto use that method as well.