Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pausing progress if it was playing and the stating again #526

Merged
merged 1 commit into from
Mar 21, 2017
Merged

Pausing progress if it was playing and the stating again #526

merged 1 commit into from
Mar 21, 2017

Conversation

deshiknaves
Copy link
Contributor

When loading a network resource, when seeking the player has really weird behavior of it continuing to play till it has buffered enough to play. Also when it is buffering, it doesn't notify that it is buffering. At least this way, some logic can be added to onProgress to track when the audio is not actually playing.

@mattapperson mattapperson merged commit 087adef into TheWidlarzGroup:master Mar 21, 2017
mattvot pushed a commit to calvium/react-native-video that referenced this pull request May 12, 2017
* master:
  Added flag for background mode (TheWidlarzGroup#563)
  issue 310 - Added a new property, ignoreSilentSwitch.  (TheWidlarzGroup#403)
  Add progressUpdateInterval to android-exoplayer (TheWidlarzGroup#540)
  Initial WPF Support (TheWidlarzGroup#385)
  added progressUpdateInterval to Android (TheWidlarzGroup#512)
  load new source if it is different (TheWidlarzGroup#502)
  Pausing progress if it was playing and the stating again (TheWidlarzGroup#526)
  bump android dependencies (TheWidlarzGroup#524)
  Update ExoPlayer to r2.2.0 (TheWidlarzGroup#505)
  Update readme (TheWidlarzGroup#497)
  [Android] App crash when unmounting video (TheWidlarzGroup#533)
  Fix/494 (TheWidlarzGroup#537)
  fix(RCTVideo.m): Fixed status bar disappearing issue
@djw27
Copy link

djw27 commented May 18, 2017

@deshiknaves can you please explain why this was added and what the intended behaviour is?

This introduced a regression for us where the 'paused' and 'rate' properties are being ignored as a result of this change. It looks like the paused and rate props are being ignored when setting the video to playing with this change.

Reproduced by seeking a video to 0 then setting the paused and rate props to pause the video. Video will autoplay from 0.

@deshiknaves
Copy link
Contributor Author

When you scrub a track, and it doesn't have it buffered already, then it continues to play until it has enough to play. Normal behavior is for it to stop and then start up when it can play.

This was to make it stop if it is playing if it's playing and then restart it when there is enough to play. Maybe it needs to check more flags?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants