Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧 Dev ➾ Provide a means of overriding all docker images #1425

Closed
10 of 11 tasks
mweichert opened this issue Oct 27, 2022 · 3 comments · Fixed by #1445
Closed
10 of 11 tasks

🚧 Dev ➾ Provide a means of overriding all docker images #1425

mweichert opened this issue Oct 27, 2022 · 3 comments · Fixed by #1445
Assignees
@mweichert
Labels
dev-task Tasks for the Taqueria Dev Board

Comments

@mweichert
Copy link
Collaborator

mweichert commented Oct 27, 2022 •
edited by hu3man
Loading

🔗 Epic|Feature Link

No response

🚥 Definition of Done

  • 🎯 Planning and Design
  • 🏎️ Dev Implementation Complete
  • ♾️ PR Merged
  • 🏆 Product Acceptance

✅ To Do

⚖️ Acceptance Criteria

✨ Functional:

  • Add a function to the Taqueria SDK like, getDockerimage(imageName: string, envVarName: string)
  • Adjust ligo plugin to use this method
  • Adjust archetype plugin to use this method
  • While we're editing relevant code, we may as well adjust any image names to use the latest version tag of the docker image.

🔭 Scope

Associated ticket: #1425

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mweichert mweichert added the dev-task Tasks for the Taqueria Dev Board label Oct 27, 2022
@hu3man
Copy link
Contributor

hu3man commented Oct 27, 2022

Is this something you can take on next sprint @mweichert ?

@jchenche jchenche self-assigned this Nov 2, 2022
@jchenche
Copy link
Contributor

jchenche commented Nov 2, 2022

Should I take on this?

@hu3man
Copy link
Contributor

hu3man commented Nov 2, 2022

I think you are the best person to do this. We'll schedule it for an upcoming sprint. As discussed, this won't work for Flextesa so it's just the compilers

It also implicitly solves the Ligo ticket for pinning a particular version of Ligo #ligo #1343

@mweichert mweichert linked a pull request Nov 3, 2022 that will close this issue
✨ Feature ➾ Allow docker images to be overwritten via environment variable (#1425) #1445
Merged
17 tasks
@jchenche jchenche assigned mweichert and unassigned jchenche Nov 17, 2022
hu3man added a commit that referenced this issue Nov 17, 2022
@alexzbusko @hu3man
✨ Feature ➾ Allow docker images to be overwritten via environment var…
3460d4c 
…iable (#1425) (#1445)

* Assure that tasks can be configured as hidden

* Added the ability to override flextesa image

* Added the ability to override LIGO image

* Finished adding tests for each plugin that can have a docker image specified by env variable

* Fixed issue with failed test

* updating tests to become modules for TS requirement

* Fix issue after merging main. Also fixed an issue with the async-retry package changing its API

* Address PR comments

* Fixed CI/CD error

Co-authored-by: Alexander Zbusko <alexander.zbusko@gmail.com>
Co-authored-by: Houston <32914364+hu3man@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mweichert mweichert

Labels
dev-task Tasks for the Taqueria Dev Board
Projects
None yet
Milestone
No milestone
3 participants
@mweichert @jchenche @hu3man