Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Dev ➾ The ability to pin to a specific version of Ligo #1343

Closed
2 of 10 tasks
Tracked by #1166
hu3man opened this issue Oct 6, 2022 · 7 comments
Closed
2 of 10 tasks
Tracked by #1166

🚧 Dev ➾ The ability to pin to a specific version of Ligo #1343

hu3man opened this issue Oct 6, 2022 · 7 comments
Assignees
Labels
dev-task Tasks for the Taqueria Dev Board

Comments

@hu3man
Copy link
Contributor

hu3man commented Oct 6, 2022

πŸ”— Epic|Feature Link

#1166

πŸš₯ Definition of Done

  • 🎯 Planning and Design
  • 🏎️ Dev Implementation (PR merged)
  • ✍️ Release Notes Added
  • πŸ† Product Acceptance

βœ… To Do

No response

βš–οΈ Acceptance Criteria

✨ Functional:

  • User can specify a Ligo version in config.json that the Ligo plugin will respect and use
  • taq originate has an optional flag where a user can provide a target version
  • The ligo plugin must provide a means to output the current version of Ligo being used
  • The order of precedence is: CLI Argument > config.json version pin, > fallback to @latest

πŸ“ Non-Functional:

  • ...

πŸ”­ Scope

πŸ™…β€β™‚οΈ Out of Scope:

  • ...

🧰 Work Description

This ticket covers the work involved in making the Ligo plugin able to use a specific version of Ligo. This is a request from the Ligo team and is something that can help users with version consistency since Taqueria defaults to @latest. The user should be able to specify an optional property in config.json where they can declare a specific version of Ligo. The taq compile task should also have an optional flag which takes a version

The plugin should detect if the current version of Ligo being used is correct and if not, retrieve the correct image and use that underlying docker container

πŸ¦„ Sizing

5

Code of Conduct

  • I agree to follow this project's Code of Conduct
@hu3man hu3man added the dev-task Tasks for the Taqueria Dev Board label Oct 6, 2022
@hu3man
Copy link
Contributor Author

hu3man commented Oct 20, 2022

@mweichert and @jchenche, this is the existing ticket for the Ligo version pinning

@zamrokk
Copy link

zamrokk commented Nov 7, 2022

Hi , I tried last 0.23.0-rc.2 version with

LIGO_DOCKER_IMAGE=ligolang/ligo:0.54.1 taq compile pokeGame.jsligo

It is fetching always ligo:0.51.0

Is it the good way to do it ?

thanks

@jchenche
Copy link
Contributor

jchenche commented Nov 7, 2022

Not sure if that release includes that feature πŸ€”

@zamrokk
Copy link

zamrokk commented Nov 8, 2022

might be why XD

@hu3man
Copy link
Contributor Author

hu3man commented Nov 22, 2022

Closing: handled by docker image override

@hu3man hu3man closed this as completed Nov 22, 2022
@zamrokk
Copy link

zamrokk commented Nov 22, 2022

which taq version ?

@jchenche
Copy link
Contributor

@zamrokk upcoming release I believe.

@hu3man right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-task Tasks for the Taqueria Dev Board
Projects
None yet
Development

No branches or pull requests

3 participants