Windows-friendly toggle buttons #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See Textualize#1934. Simply put: the character that we were doesn't render well at all in Windows Terminal on Windows 10; while there are other options available, few seem to work well there either. So here we go for a bold X; this should render fine everywhere.
See Textualize#1934. Simply put: the character that we were using doesn't render well at all in Windows Terminal on Windows 10 or 11. This one isn't ideal as it sits a little low, at least in some environments. I want to try this one on for a wee bit and see how we feel about it. Honestly, I'm not 100% happy with it; but right now it's the least-worst option I've tried.
davep
requested review from
rodrigogiraoserrao,
willmcgugan and
darrenburns
and removed request for
rodrigogiraoserrao and
willmcgugan
darrenburns
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #1934 -- a tweak to the characters used for
CheckboxandRadioButtonso that they work in Windows Terminal on Windows 10 and 11.