Merge pull request #1951 from davep/windows-friendly-toggle-buttons

Windows-friendly toggle buttons
Textualize · Mar 6, 2023 · 98cc1a7 · 98cc1a7
2 parents 8facffe + 286293b
commit 98cc1a7
Show file tree

Hide file tree

Showing 4 changed files with 189 additions and 186 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Breaking change: Messages don't require a `sender` in their constructor https://github.com/Textualize/textual/pull/1940
 - Many messages have grown a `control` property which returns the control they relate to. https://github.com/Textualize/textual/pull/1940
 - Dropped `time` attribute from Messages https://github.com/Textualize/textual/pull/1940
+- Changed the `Checkbox` character due to issues with Windows Terminal and Windows 10 https://github.com/Textualize/textual/issues/1934
+- Changed the `RadioButton` character due to issues with Windows Terminal and Windows 10 and 11 https://github.com/Textualize/textual/issues/1934
 
 ### Added
 

diff --git a/src/textual/widgets/_radio_button.py b/src/textual/widgets/_radio_button.py
@@ -12,7 +12,7 @@ class RadioButton(ToggleButton):
         A `RadioButton` is best used within a [RadioSet][textual.widgets.RadioSet].
     """
 
-    BUTTON_INNER = "⏺"
+    BUTTON_INNER = "\u25CF"
     """The character used for the inside of the button."""
 
     class Changed(ToggleButton.Changed):

diff --git a/src/textual/widgets/_toggle_button.py b/src/textual/widgets/_toggle_button.py
@@ -65,6 +65,7 @@ class ToggleButton(Static, can_focus=True):
 
     ToggleButton > .toggle--button {
         color: $background;
+        text-style: bold;
         background: $foreground 15%;
     }
 
@@ -99,7 +100,7 @@ class ToggleButton(Static, can_focus=True):
     BUTTON_LEFT: str = "▐"
     """The character used for the left side of the toggle button."""
 
-    BUTTON_INNER: str = "✖"
+    BUTTON_INNER: str = "X"
     """The character used for the inside of the button."""
 
     BUTTON_RIGHT: str = "▌"