fix: correctly handle access when moving a file #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbreuss
force-pushed
the
bugfix/870-move-file-with-readonly-attribute
branch
from
c757dbb to
3de0256
Compare
Fix function call order also in second `Move` method
vbreuss
force-pushed
the
bugfix/870-move-file-with-readonly-attribute
branch
from
3de0256 to
a008c15
Compare
fgreinacher
reviewed
Aug 11, 2022
fgreinacher
changed the title
|
Thanks a ton @vbreuss! |
fgreinacher
approved these changes
Aug 15, 2022
|
This is addressed in release v17.0.28. |
This was referenced Aug 15, 2022
vbreuss
added a commit
to vbreuss/System.IO.Abstractions
that referenced
this pull request
Aug 26, 2022
…bleIO#873) Fix function call order also in second `Move` method Co-authored-by: Valentin Breuß <v.breuss@tig.at>
This was referenced Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #870:
Change the order when moving files:
Also added a unit test to verify the behavior.