fix: #870 Moving a readonly file duplicates the file

TestableIO · Aug 9, 2022 · c757dbb · c757dbb
1 parent e8ed38b
commit c757dbb
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/System.IO.Abstractions.TestingHelpers/MockFile.cs b/src/System.IO.Abstractions.TestingHelpers/MockFile.cs
@@ -397,8 +397,8 @@ public override void Move(string sourceFileName, string destFileName)
             }
             VerifyDirectoryExists(destFileName);
 
-            mockFileDataAccessor.AddFile(destFileName, new MockFileData(sourceFile));
             mockFileDataAccessor.RemoveFile(sourceFileName);
+            mockFileDataAccessor.AddFile(destFileName, new MockFileData(sourceFile));
         }
 
 #if FEATURE_FILE_MOVE_WITH_OVERWRITE

diff --git a/tests/System.IO.Abstractions.TestingHelpers.Tests/MockFileMoveTests.cs b/tests/System.IO.Abstractions.TestingHelpers.Tests/MockFileMoveTests.cs
@@ -27,6 +27,21 @@ public void MockFile_Move_ShouldMoveFileWithinMemoryFileSystem()
             Assert.That(fileSystem.FileExists(sourceFilePath), Is.False);
         }
 
+        [Test]
+        public void MockFile_Move_WithReadOnlyAttribute_ShouldThrowUnauthorizedAccessExceptionAndNotMoveFile()
+        {
+            var sourceFilePath = @"c:\foo.txt";
+            var destFilePath = @"c:\bar.txt";
+            var fileSystem = new MockFileSystem();
+            fileSystem.File.WriteAllText(sourceFilePath, "this is some content");
+            fileSystem.File.SetAttributes(sourceFilePath, FileAttributes.ReadOnly);
+
+            Assert.Throws<UnauthorizedAccessException>(() => fileSystem.File.Move(sourceFilePath, destFilePath));
+
+            Assert.That(fileSystem.File.Exists(sourceFilePath), Is.EqualTo(true));
+            Assert.That(fileSystem.File.Exists(destFilePath), Is.EqualTo(false));
+        }
+
         [Test]
         public void MockFile_Move_SameSourceAndTargetIsANoOp()
         {