fix: add LinkTarget to IFileSystemInfo
#795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianMcBrayer
changed the title
LinkTarget to IFileSystemInfoLinkTarget to IFileSystemInfo
|
@fgreinacher I missed this during my last PR. Sorry! |
|
On a related note, I do not think the tests are testing using .net6, or else they would have blown up (I think). Taking a look. |
fgreinacher
changed the title
LinkTarget to IFileSystemInfoLinkTarget to IFileSystemInfo
|
Thanks @BrianMcBrayer! The tests are indeed running against .NET 6, but they don't assert that interfaces and base classes are equivalent. Might be something to improve 🤔 |
|
This is addressed in release v16.1.2. |
This was referenced Jan 12, 2022
Update dependency System.IO.Abstractions to v16.1.25
TestableIO/System.IO.Abstractions.Analyzers#144
Merged
This was referenced Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #790 we added
LinkTargettoFileSystemInfoBase, but I forgot to also add it to the interface (which was the whole point in the first place).So this is embarrassing, but also it will allow
LinkTargetto be used and mocked.