Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add LinkTarget to FileSystemInfo for .NET 6 targets #790

Merged
merged 8 commits into from
Jan 11, 2022
Merged

feat: Add LinkTarget to FileSystemInfo for .NET 6 targets #790

merged 8 commits into from
Jan 11, 2022

Conversation

BrianMcBrayer
Copy link
Contributor

Overview

In .NET 6, additional symlinks support was added to FileSystemInfo. This PR adds at least one of those properties here, the LinkTarget property.

See #789

We need to discuss the mock portion of this though as I'm not sure how this codebase expects that.

@BrianMcBrayer BrianMcBrayer changed the title Add LinkTarget to FileSystemInfo for .NET 6 targets feat: Add LinkTarget to FileSystemInfo for .NET 6 targets Jan 7, 2022
@BrianMcBrayer
Copy link
Contributor Author

I think that this is probably a minor version bump, since it adds to the API without changing existing APIs? But I'm not sure.

fgreinacher
fgreinacher suggested changes Jan 8, 2022
View reviewed changes
Copy link
Contributor

@fgreinacher fgreinacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @BrianMcBrayer! Left some comments inline

src/System.IO.Abstractions.TestingHelpers/MockDirectoryInfo.cs Outdated Show resolved Hide resolved
src/System.IO.Abstractions.TestingHelpers/MockDirectoryInfo.cs Outdated Show resolved Hide resolved
src/System.IO.Abstractions.TestingHelpers/MockFileInfo.cs Outdated Show resolved Hide resolved
src/System.IO.Abstractions.TestingHelpers/System.IO.Abstractions.TestingHelpers.csproj Show resolved Hide resolved
src/System.IO.Abstractions/DirectoryInfoWrapper.cs Outdated Show resolved Hide resolved
src/System.IO.Abstractions/FileInfoWrapper.cs Outdated Show resolved Hide resolved
src/System.IO.Abstractions/FileSystemInfoBase.cs Outdated Show resolved Hide resolved
tests/System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryArgumentPathTests.cs Show resolved Hide resolved
src/System.IO.Abstractions.TestingHelpers/MockFileInfo.cs Outdated Show resolved Hide resolved
@BrianMcBrayer
Copy link
Contributor Author

Thank you! I'll try to update it all today

BrianMcBrayer
BrianMcBrayer commented Jan 8, 2022
View reviewed changes
Copy link
Contributor Author

@BrianMcBrayer BrianMcBrayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I addressed all the comments

src/System.IO.Abstractions.TestingHelpers/MockDirectoryInfo.cs Outdated Show resolved Hide resolved
src/System.IO.Abstractions.TestingHelpers/MockDirectoryInfo.cs Outdated Show resolved Hide resolved
src/System.IO.Abstractions.TestingHelpers/MockFileInfo.cs Outdated Show resolved Hide resolved
src/System.IO.Abstractions.TestingHelpers/MockFileInfo.cs Outdated Show resolved Hide resolved
src/System.IO.Abstractions/DirectoryInfoWrapper.cs Outdated Show resolved Hide resolved
src/System.IO.Abstractions/FileInfoWrapper.cs Outdated Show resolved Hide resolved
src/System.IO.Abstractions/FileSystemInfoBase.cs Outdated Show resolved Hide resolved
@BrianMcBrayer BrianMcBrayer marked this pull request as ready for review January 8, 2022 16:35
@BrianMcBrayer
Copy link
Contributor Author

Note that this PR is pending #791 because of the enhancements that will add to MockFileInfo

fgreinacher
fgreinacher approved these changes Jan 9, 2022
View reviewed changes
Copy link
Contributor

@fgreinacher fgreinacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good @BrianMcBrayer 👍

Happy to merge after you rebased/adapted the Mock implementation!

Brian McBrayer added 3 commits January 10, 2022 10:49
Added LinkTarget to FileSystemInfo for .NET 6 targets. Updated te…
dcf9e69 
…st snapshots as well. Added mock stubs, but we need to discuss what a better mock implementation would look like.
Addressed code review comments.
6a43419
Updated MockFileInfo to latest mocking standards
467a1c4
@BrianMcBrayer BrianMcBrayer force-pushed the bug/add-link-target-file-system-info branch from 2ffb094 to 467a1c4 Compare January 10, 2022 15:52
@BrianMcBrayer
Copy link
Contributor Author

@fgreinacher it should be all updated to the latest mocking standards. Let me know if there are any additional changes needed though! Otherwise, I think it's ready to merge after checks pass.

fgreinacher
fgreinacher suggested changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@fgreinacher fgreinacher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrianMcBrayer Thanks again, I left some minor suggestions. Please also bump the minor version in https://github.com/BrianMcBrayer/System.IO.Abstractions/blob/bug/add-link-target-file-system-info/version.json#L3 to indicate the new feature.

Directory.Build.props Outdated Show resolved Hide resolved
src/System.IO.Abstractions.TestingHelpers/MockDirectoryInfo.cs Outdated Show resolved Hide resolved
src/System.IO.Abstractions.TestingHelpers/MockFileData.cs Outdated Show resolved Hide resolved
src/System.IO.Abstractions.TestingHelpers/MockFileInfo.cs Outdated Show resolved Hide resolved
BrianMcBrayer and others added 4 commits January 11, 2022 12:17
@BrianMcBrayer @fgreinacher
Update Directory.Build.props
472be45 
Co-authored-by: Florian Greinacher <florian@greinacher.de>
@BrianMcBrayer @fgreinacher
Update src/System.IO.Abstractions.TestingHelpers/MockDirectoryInfo.cs
c1a9d21 
Co-authored-by: Florian Greinacher <florian@greinacher.de>
@BrianMcBrayer @fgreinacher
Update src/System.IO.Abstractions.TestingHelpers/MockFileData.cs
40591af 
Co-authored-by: Florian Greinacher <florian@greinacher.de>
@BrianMcBrayer @fgreinacher
Update src/System.IO.Abstractions.TestingHelpers/MockFileInfo.cs
c588545 
Co-authored-by: Florian Greinacher <florian@greinacher.de>
@BrianMcBrayer
Copy link
Contributor Author

@fgreinacher I accepted your review comments. Can't believe I didn't indent those things correctly. I think the conditional comments threw me off, which is silly.

fgreinacher
fgreinacher suggested changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@fgreinacher fgreinacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton @BrianMcBrayer and no worries about the minor style issues.

Please bump the minor version in https://github.com/BrianMcBrayer/System.IO.Abstractions/blob/bug/add-link-target-file-system-info/version.json#L3 to indicate the new feature. I would have done this myself but cannot commit to your branch (you can allow that by ticking the "Allow edits and access to secrets by maintainers" checkbox on the right).

@fgreinacher fgreinacher enabled auto-merge (squash) January 11, 2022 20:35
fgreinacher
fgreinacher approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@fgreinacher fgreinacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great now, thanks for addressing everything so quickly!

@fgreinacher fgreinacher disabled auto-merge January 11, 2022 20:52
@fgreinacher fgreinacher merged commit ba59ebe into TestableIO:main Jan 11, 2022
@BrianMcBrayer BrianMcBrayer deleted the bug/add-link-target-file-system-info branch January 11, 2022 21:23
@github-actions
Copy link

This is addressed in release v16.1.1.

@github-actions github-actions bot added the state: released Issues that are released label Jan 11, 2022
This was referenced Jan 11, 2022
Merged
Merged
Merged
@BrianMcBrayer BrianMcBrayer mentioned this pull request Jan 12, 2022
Merged
@renovate renovate bot mentioned this pull request Jan 16, 2022
Open
1 task
This was referenced Feb 11, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgreinacher fgreinacher fgreinacher approved these changes

Assignees
No one assigned
Labels
state: released Issues that are released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrianMcBrayer @fgreinacher