Add in details view video playing. #551
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok well, this is not perfect but it should give a base for further modifications.
I searched the net to embed an Activity inside a Fragment, or a Fragment into
another Fragment but didn't found how. So i just made some copy/paste + code
modifications to enable in details view Video playing, avoiding to open another
activity. This can be enabled via the settings (disabled by default) and is an
experimental stuff, probably not meant to be merged, but at least, it works!
Hope something more competent than me in Android development (cc @theScrabi) will
take a look at this and found a way to make the code smarter.
This PR tries to address the issue #528 :p
There are still issues:
MediaController
without changing completly the view Theme.PlayerVideoActivity.java
My best hope is to convert the PlayerVideoActivity as a reusable View that we could just load with some arguments instead of all that garbage code. c:
Enjoy!
Debug APK !