Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

play without full screen #528

Closed
2 tasks done
ghost opened this issue May 3, 2017 · 24 comments · Fixed by #2907
Closed
2 tasks done

play without full screen #528

ghost opened this issue May 3, 2017 · 24 comments · Fixed by #2907
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@ghost
Copy link

ghost commented May 3, 2017

  • I carefully read the contribution guidelines and agree to them.
  • I checked if the issue/feature exists in the latest version.

it will nice to play video without full screen.

@theScrabi
Copy link
Member

Please give a small explenation.

@ghost
Copy link
Author

ghost commented May 3, 2017

when I click on play button it looks like this

screenshot_2017-05-03-21-45-27

but I like playing this way (I know popup will be resizable.)

screenshot_2017-05-03-21-46-25

@ghost
Copy link
Author

ghost commented May 3, 2017

I played some videos but all of them works this way. (I am using android 4.2.2)

@ghost
Copy link
Author

ghost commented May 3, 2017

@theScrabi

I was trying to build it myself (not a Android dev) with AIDE.

but it can not find 'APPLICATION_ID' and 'VERSION_NAME' (not a member of BuildConfig). how to generate them? (tried to add buildConfigField with no luck)

@theScrabi
Copy link
Member

Hm strange, version code and version name can be found here

Did you try to build the app without the IDEA Ide? You could try to build it via commandline:
[dir/to/NewPipe/root: ]$ ./gradlew assemble

@ghost
Copy link
Author

ghost commented May 4, 2017

I was trying to build it on android (AIDE is a android app).

it seems, it was a problem of AIDE
(https://plus.google.com/112950748876729349038/posts/8wKAAqaqVEm).

@theScrabi
Copy link
Member

Please use your computer to build it.

@SkyzohKey
Copy link

@theScrabi I guess he's wanting to say that the player should be able to play the video without going fullscreen as it currently do. Something similar to how YouTube official app handle that. :)

@ghost
Copy link
Author

ghost commented May 11, 2017

@SkyzohKey exactly. I can get expected result by using resizable popup.

@SkyzohKey
Copy link

I'm working on this right now, you can expect a PR at the end of the day I guess.

@ghost
Copy link
Author

ghost commented May 11, 2017

@SkyzohKey 😄

@SkyzohKey
Copy link

SkyzohKey commented May 11, 2017

OK it's almost ready. That's the first time I contribute to Java/Android code, I come from a C/Vala/PHP background so my code is probably really shitty but I hope it make @theScrabi to understand what I'm speaking about. 😂

@mauriciocolli
Copy link
Contributor

We already got rid of this VideoView, take a look at the player package, you can find implementations of ExoPlayer that you can easily plug in the fragment.

@SkyzohKey
Copy link

@mauriciocolli Just copied some code from the actual player from PlayVideoActivity.java :/

@mauriciocolli
Copy link
Contributor

@SkyzohKey that's the old player, just ignore it, look at the others for examples

@SkyzohKey
Copy link

Do you have an example file ?

@Zero3K
Copy link

Zero3K commented Aug 22, 2017

Any news regarding the implementing of this suggestion?

@theScrabi
Copy link
Member

What do you mean by that?

@anursetiawan
Copy link

So.. any news about this issue? Is playing without fullscreen will be implemented? Being worked on? Or simply "won't fix"?

@ghost
Copy link
Author

ghost commented Sep 9, 2017 via email

@stale
Copy link

stale bot commented Dec 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2018
@Stypox Stypox added the feature request Issue is related to a feature in the app label Jun 23, 2019
@Stypox Stypox added the GUI Issue is related to the graphical user interface label Jul 18, 2019
@TobiGr TobiGr removed the stale label Jul 19, 2019
@sucotronic
Copy link

I've reviewed de open PRs and seems that nobody is working just now on this. I could give it a try, just want to know that I'm not duplicating work ;)

@B0pol B0pol added the pr open label May 10, 2020
@B0pol B0pol linked a pull request May 10, 2020 that will close this issue
@arihan-1560795
Copy link

Wanted to comment that playing videos in portrait mode without it switching to fullscreen so I may read comments/ look at other suggested videos would be really nice! A work around right now is to have the stream "pop up", but this isn't really elegant.

@Stypox
Copy link
Member

Stypox commented Jul 28, 2020

#2907 @arihan-1560795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants