-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
play without full screen #528
Comments
Please give a small explenation. |
I played some videos but all of them works this way. (I am using android 4.2.2) |
I was trying to build it myself (not a Android dev) with AIDE. but it can not find 'APPLICATION_ID' and 'VERSION_NAME' (not a member of BuildConfig). how to generate them? (tried to add |
Hm strange, version code and version name can be found here Did you try to build the app without the IDEA Ide? You could try to build it via commandline: |
I was trying to build it on android (AIDE is a android app). it seems, it was a problem of AIDE |
Please use your computer to build it. |
@theScrabi I guess he's wanting to say that the player should be able to play the video without going fullscreen as it currently do. Something similar to how YouTube official app handle that. :) |
@SkyzohKey exactly. I can get expected result by using resizable popup. |
I'm working on this right now, you can expect a PR at the end of the day I guess. |
OK it's almost ready. That's the first time I contribute to Java/Android code, I come from a C/Vala/PHP background so my code is probably really shitty but I hope it make @theScrabi to understand what I'm speaking about. 😂 |
We already got rid of this VideoView, take a look at the |
@mauriciocolli Just copied some code from the actual player from |
@SkyzohKey that's the old player, just ignore it, look at the others for examples |
Do you have an example file ? |
Any news regarding the implementing of this suggestion? |
What do you mean by that? |
So.. any news about this issue? Is playing without fullscreen will be implemented? Being worked on? Or simply "won't fix"? |
It currently isn't being worked on, since we're busy with more important
things, like improving playlist support.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I've reviewed de open PRs and seems that nobody is working just now on this. I could give it a try, just want to know that I'm not duplicating work ;) |
Wanted to comment that playing videos in portrait mode without it switching to fullscreen so I may read comments/ look at other suggested videos would be really nice! A work around right now is to have the stream "pop up", but this isn't really elegant. |
it will nice to play video without full screen.
The text was updated successfully, but these errors were encountered: