Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling in description tab #5460

Closed
wants to merge 1 commit into from

Conversation

Stypox
Copy link
Member

@Stypox Stypox commented Jan 19, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

The problem was caused by NestedScrollView being used as the root view for the fragment. Now everything was wrapped in a FrameLayout.

Fixes the following issue(s)

Fixes #5453

Due diligence

@XiangRongLin XiangRongLin added the bug Issue is related to a bug label Jan 19, 2021
@Stypox Stypox force-pushed the fix-scroll-description branch 2 times, most recently from 87584b0 to 6a2bfef Compare January 23, 2021 16:35
@Stypox Stypox force-pushed the fix-scroll-description branch from 6a2bfef to 08501e5 Compare January 23, 2021 17:05
@Stypox
Copy link
Member Author

Stypox commented Feb 1, 2021

I've tried to solve this for some time now, but every attempt I did failed. :-(
I'm closing this PR since it doesn't solve anything.

@Stypox Stypox closed this Feb 1, 2021
@Stypox Stypox deleted the fix-scroll-description branch August 4, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Secondary controls] Scrolling bug when opening links at the top of the description of a video
2 participants