Fix scrolling in description tab

app/src/main/java/org/schabi/newpipe/fragments/detail/DescriptionNestedScrollView.java

@@ -0,0 +1,49 @@
+package org.schabi.newpipe.fragments.detail;
+
+import android.content.Context;
+import android.graphics.Rect;
+import android.util.AttributeSet;
+
+import androidx.annotation.NonNull;
+import androidx.annotation.Nullable;
+import androidx.core.widget.NestedScrollView;
+
+/**
+ * The behaviour of this scroll view is exactly equal to that of {@link NestedScrollView} except
+ * that it does not scroll automatically to give focus to views (unwanted since everything would
+ * move around when clicking on links, see #5453).
+ */
+public class DescriptionNestedScrollView extends NestedScrollView {
+
+    public DescriptionNestedScrollView(@NonNull final Context context) {
+        super(context);
+    }
+
+    public DescriptionNestedScrollView(@NonNull final Context context,
+                                       @Nullable final AttributeSet attrs) {
+        super(context, attrs);
+    }
+
+    public DescriptionNestedScrollView(@NonNull final Context context,
+                                       @Nullable final AttributeSet attrs,
+                                       final int defStyleAttr) {
+        super(context, attrs, defStyleAttr);
+    }
+
+    @Override
+    protected int computeScrollDeltaToGetChildRectOnScreen(final Rect rect) {
+        // Override this to return always 0 so that the description scroll view is not scrolled
+        // around when the user presses on a link
+        return 0;
+    }
+
+    @Override
+    public void scrollTo(final int x, final int y) {
+        // Override this to prevent any scrolling
+    }
+
+    @Override
+    public void scrollBy(final int x, final int y) {
+        // Override this to prevent any scrolling
+    }
+}

app/src/main/res/layout/fragment_description.xml

@@ -1,11 +1,11 @@
 <?xml version="1.0" encoding="utf-8"?>
-<androidx.core.widget.NestedScrollView xmlns:android="http://schemas.android.com/apk/res/android"
+<org.schabi.newpipe.fragments.detail.DescriptionNestedScrollView xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
-    android:orientation="vertical"
-    android:scrollbars="vertical"
     android:layout_width="match_parent"
-    android:layout_height="wrap_content">
+    android:layout_height="wrap_content"
+    android:orientation="vertical"
+    android:scrollbars="vertical">
 
     <androidx.constraintlayout.widget.ConstraintLayout
         android:layout_width="match_parent"
@@ -15,9 +15,8 @@
             android:id="@+id/detail_upload_date_view"
             android:layout_width="0dp"
             android:layout_height="wrap_content"
-            android:layout_marginStart="16dp"
+            android:layout_marginHorizontal="16dp"
             android:layout_marginTop="6dp"
-            android:layout_marginEnd="16dp"
             android:textAppearance="?android:attr/textAppearanceMedium"
             android:textSize="@dimen/video_item_detail_upload_date_text_size"
             android:textStyle="bold"
@@ -29,11 +28,10 @@
 
         <TextView
             android:id="@+id/detail_description_view"
-            android:layout_width="match_parent"
+            android:layout_width="0dp"
             android:layout_height="wrap_content"
-            android:layout_marginStart="16dp"
+            android:layout_marginHorizontal="16dp"
             android:layout_marginTop="8dp"
-            android:layout_marginEnd="16dp"
             android:layout_marginBottom="16dp"
             android:textAppearance="?android:attr/textAppearanceMedium"
             android:textIsSelectable="true"
@@ -45,4 +43,4 @@
             app:layout_constraintVertical_bias="0.0"
             tools:text="Description Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed a ultricies ex. Integer sit amet sodales risus. Duis non mi et urna pretium bibendum." />
     </androidx.constraintlayout.widget.ConstraintLayout>
-</androidx.core.widget.NestedScrollView>
+</org.schabi.newpipe.fragments.detail.DescriptionNestedScrollView>