Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to play downloaded videos #478

Closed
2 tasks done
TheDcoder opened this issue Mar 13, 2017 · 51 comments
Closed
2 tasks done

Ability to play downloaded videos #478

TheDcoder opened this issue Mar 13, 2017 · 51 comments
Labels
downloader Issue is related to the downloader feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background) wontfix This issue will not be fixed

Comments

@TheDcoder
Copy link

TheDcoder commented Mar 13, 2017

  • I carefully read the contribution guidelines and agree to them.
  • I checked if the issue/feature exists in the latest version.

Hi, I think it would be nice if NewPipe was able to play downloaded videos... much like Youtube's "Save Offline" feature.
People with phones which do not support playback of WebM might find this very useful!

@ssibb in #3932 also suggested the ability to watch the video file while it is being downloaded, in order to be able to judge the quality without wasting data by fetching the video twice (i.e. for viewing and for downloading).

@theScrabi
Copy link
Member

Well, but this is a feature you can easily fix yourself by installing a player that can handle webm, or download the videos in mp4 format.

I'd say this is not a top level feature.

@theScrabi theScrabi added the feature request Issue is related to a feature in the app label Mar 14, 2017
@TheDcoder
Copy link
Author

@theScrabi Some propitiatory players might be able to do that but in my phone VLC does not work since my phone is a low-end android device 😞. I want to keep it as free as possible. Another reason for not using mp4 is that its not a free format... WebM is. and WebM files are smaller too so less data usage!

I hope you understand me :)

@turboteckel
Copy link

Isn't MPEG4 smaller than WebM in most cases on YouTube?

@TheDcoder
Copy link
Author

@turboteckel Did not know that. When I produce my videos using Camtasia (it makes mp4) I encode it into WebM which makes the file a lot smaller without decreasing quality!

@kasbah
Copy link

kasbah commented Sep 5, 2018

Really liking NewPipe but they way this is at the moment confused me. I downloaded videos to be able to play them in background (love that feature!) but guessing from this issue when I then play them in NewPipe it is not actually playing back my downloaded videos, rather it's downloading them again by streaming them?

@theScrabi
Copy link
Member

NewPipe it is not actually playing back my downloaded videos, rather it's downloading them again by streaming them?

Yes, if you download them it's supposed to listen to them by the internal music player.

@kasbah
Copy link

kasbah commented Sep 5, 2018

Ah, in that case it would be good to add a "play in NewPipe" option in the downloads menu.

@theScrabi
Copy link
Member

We need to se if that it possible with our player.

@stale

This comment has been minimized.

@stale stale bot added the stale label Dec 1, 2018
@ganguin
Copy link

ganguin commented Dec 10, 2018

Is this issue on track? It would be nice that newpipe is able to play downloaded content, especially for some newpipe features: play in the background and play in a popup. Or is there a nice an alternative audio/video that can do that?

@TheDcoder
Copy link
Author

Still waiting for @theScrabi to confirm the possibility of this happening with the current player in NewPipe

@alayoubiyoun
Copy link

Our player of Newpipe i love it, but i want it to play just offline music with that playback(ignore silence+Tempo+Pitch) can you help plz

@Stypox Stypox added the downloader Issue is related to the downloader label Jul 18, 2019
@TobiGr TobiGr removed the stale label Jul 19, 2019
@Stypox Stypox added the player Issues related to any player (main, popup and background) label Aug 27, 2019
@opusforlife2
Copy link
Collaborator

@theScrabi If Newpipe stores in a database the file path of videos/audios when they are being downloaded, is it not possible for Exoplayer to play them by accessing the same file path?

@brunoais
Copy link

I believe that, for now, if I try to view a video that has already been downloaded, the app can prompt the user if the user wants to open the file instead with a video viewer.
I think that is more comfortable to do than to deal with redownloads or thinking you are downloading and can then watch later but you cannot.

In my phone, I only have space for some apps and that's it. Only 16GB doesn't give much margin of error, only 9GB, from which I need 1GB free in order to be able to update the apps

@opusforlife2
Copy link
Collaborator

I believe that, for now, if I try to view a video that has already been downloaded, the app can prompt the user if the user wants to open the file instead with a video viewer.

@brunoais That is already the case. Try it.

@litetex
Copy link
Member

litetex commented Nov 4, 2021

Thank you all for the feedback and participating in this issue.

After ~3 weeks of waiting for votes in #478 (comment) the poll turned out to be an overwhelmingly "don't do it".

I also - again - looked through the comments since I posted the poll but I didn't find anything that fundamentally changed the situation/statements (and that was not already answered by another dev).

Fun Fact

I "surfed the web" a bit and found an offline player implementation, that was done by a fork:
grafik
But the implementation is so simple and lacking a ton of features (e.g. seekbar thumbnail preview, replay-speed, mute button, full screen button etc) that every external/pre-installed player like e.g. VLC is doing the job better.
Things like mentioned in #478 (comment) would never be satisfied by such a simple implementation.

Therefore this issue will be closed as out of scope and we will put a statement onto the website (TeamNewPipe/website#260).

@litetex litetex closed this as completed Nov 4, 2021
@brunoais
Copy link

brunoais commented Nov 4, 2021

@litetex Wait what?
I thought the thumbs down was in opposition to the proposal for not doing it!

Declare it out of scope and don't do it.

Do we want to do this?

So, for me, the question was (below is my interpretation):
"Do we want to consider out of scope?
👍 - Agree. Out of scope for this project
😕 - no idea / neutral / abstention
👎 - Disagree, it's in scope for this project
"

Did others also vote with this philosophy?

@triallax
Copy link
Contributor

triallax commented Nov 4, 2021

Probably not the team members, no.

@opusforlife2
Copy link
Collaborator

Did others also vote with this philosophy?

The team was already talking about not doing it before we started posting here. So it would be quite weird if the team members suddenly took the opposite stand. xD

@brunoais
Copy link

brunoais commented Nov 4, 2021

Oh... I see... Thanks for answering

@0Karakurt0
Copy link

0Karakurt0 commented Nov 22, 2021

Well, sad to hear it, but I do understand the reasons.
I came to this issue looking for HDR support, as of right now NewPipe's fork is the only player capable of playing some HDR on my phone. But I don't have a good internet to stream higher resolutions...
It would be awesome if support was added only for downloaded videos, even without file dialog or music player interface, that seems to be the lesser evil, if feature is marked as unsupported and therefore all issues are declined.

@opusforlife2
Copy link
Collaborator

@0Karakurt0 Try the player linked here: #478 (comment) (https://github.com/moneytoo/Player#supported-formats says HDR is supported.)

@0Karakurt0
Copy link

@opusforlife2 VLC also says that support it, and CxM..? Cx-something is supposedly created exactly for that but it is the only one player that managed to mangle the video beyond recognition.
But thanks, I'll try it out

@opusforlife2
Copy link
Collaborator

@0Karakurt0 I recommended this to you specifically because you talked about Newpipe's 'player' working, which is basically Google's Exoplayer. This app is also based on Exoplayer.

@0Karakurt0
Copy link

@opusforlife2 thanks, works like a charm and does nothing more, awesome player.
I would love it to also support urls, but it seems to be an old issue.

@woj-tek
Copy link
Contributor

woj-tek commented Jan 5, 2023

Hi,
late to the party but I was just faced with similar issue. Downloading works just fine, but one of the best features / abilities of NewPipe is track what I already watched and till what point. Yes, there are external players that can play fields and even remember position but this information is lost after a while and if I go back to some video I may not remember if I watched (I use NewPipe as my all YT client with all history)

@SameenAhnaf SameenAhnaf added the wontfix This issue will not be fixed label Jan 6, 2023
@SameenAhnaf SameenAhnaf closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2023
@Inwerpsel
Copy link

Inwerpsel commented Nov 8, 2023

It's quite unfortunate to see a perfectly reasonable feature request being closed as "not planned". Just because it's not a priority at some point in time doesn't mean it's not useful or even too much work. You can save a lot of bandwidth this way if you're watching a video over and over for learning.

Since the player already has the ability to save to disk, you could could keep a database with all downloaded video IDs and a path on disk. Then, upon playback, you check if the video is in this database. Then you check if it's still on the filesystem. Finally you load the mp4 from the local file system, instead of over the network.

Maybe I'm missing something, but this doesn't seem complicated at all (compared to the downloading which is already there), and would give a lot of value.

@opusforlife2
Copy link
Collaborator

See #10542.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
downloader Issue is related to the downloader feature request Issue is related to a feature in the app player Issues related to any player (main, popup and background) wontfix This issue will not be fixed
Projects
None yet
Development

No branches or pull requests