-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to play downloaded videos #478
Comments
Well, but this is a feature you can easily fix yourself by installing a player that can handle webm, or download the videos in mp4 format. I'd say this is not a top level feature. |
@theScrabi Some propitiatory players might be able to do that but in my phone VLC does not work since my phone is a low-end android device 😞. I want to keep it as free as possible. Another reason for not using mp4 is that its not a free format... WebM is. and WebM files are smaller too so less data usage! I hope you understand me :) |
Isn't MPEG4 smaller than WebM in most cases on YouTube? |
@turboteckel Did not know that. When I produce my videos using Camtasia (it makes mp4) I encode it into WebM which makes the file a lot smaller without decreasing quality! |
Really liking NewPipe but they way this is at the moment confused me. I downloaded videos to be able to play them in background (love that feature!) but guessing from this issue when I then play them in NewPipe it is not actually playing back my downloaded videos, rather it's downloading them again by streaming them? |
Yes, if you download them it's supposed to listen to them by the internal music player. |
Ah, in that case it would be good to add a "play in NewPipe" option in the downloads menu. |
We need to se if that it possible with our player. |
This comment has been minimized.
This comment has been minimized.
Is this issue on track? It would be nice that newpipe is able to play downloaded content, especially for some newpipe features: play in the background and play in a popup. Or is there a nice an alternative audio/video that can do that? |
Still waiting for @theScrabi to confirm the possibility of this happening with the current player in NewPipe |
Our player of Newpipe i love it, but i want it to play just offline music with that playback(ignore silence+Tempo+Pitch) can you help plz |
@theScrabi If Newpipe stores in a database the file path of videos/audios when they are being downloaded, is it not possible for Exoplayer to play them by accessing the same file path? |
I believe that, for now, if I try to view a video that has already been downloaded, the app can prompt the user if the user wants to open the file instead with a video viewer. In my phone, I only have space for some apps and that's it. Only 16GB doesn't give much margin of error, only 9GB, from which I need 1GB free in order to be able to update the apps |
@brunoais That is already the case. Try it. |
Thank you all for the feedback and participating in this issue. After ~3 weeks of waiting for votes in #478 (comment) the poll turned out to be an overwhelmingly "don't do it". I also - again - looked through the comments since I posted the poll but I didn't find anything that fundamentally changed the situation/statements (and that was not already answered by another dev). Fun FactI "surfed the web" a bit and found an offline player implementation, that was done by a fork: Therefore this issue will be closed as out of scope and we will put a statement onto the website (TeamNewPipe/website#260). |
@litetex Wait what?
So, for me, the question was (below is my interpretation): Did others also vote with this philosophy? |
Probably not the team members, no. |
The team was already talking about not doing it before we started posting here. So it would be quite weird if the team members suddenly took the opposite stand. xD |
Oh... I see... Thanks for answering |
Well, sad to hear it, but I do understand the reasons. |
@0Karakurt0 Try the player linked here: #478 (comment) (https://github.com/moneytoo/Player#supported-formats says HDR is supported.) |
@opusforlife2 VLC also says that support it, and CxM..? Cx-something is supposedly created exactly for that but it is the only one player that managed to mangle the video beyond recognition. |
@0Karakurt0 I recommended this to you specifically because you talked about Newpipe's 'player' working, which is basically Google's Exoplayer. This app is also based on Exoplayer. |
@opusforlife2 thanks, works like a charm and does nothing more, awesome player. |
Hi, |
It's quite unfortunate to see a perfectly reasonable feature request being closed as "not planned". Just because it's not a priority at some point in time doesn't mean it's not useful or even too much work. You can save a lot of bandwidth this way if you're watching a video over and over for learning. Since the player already has the ability to save to disk, you could could keep a database with all downloaded video IDs and a path on disk. Then, upon playback, you check if the video is in this database. Then you check if it's still on the filesystem. Finally you load the mp4 from the local file system, instead of over the network. Maybe I'm missing something, but this doesn't seem complicated at all (compared to the downloading which is already there), and would give a lot of value. |
See #10542. |
Hi, I think it would be nice if NewPipe was able to play downloaded videos... much like Youtube's "Save Offline" feature.
People with phones which do not support playback of WebM might find this very useful!
@ssibb in #3932 also suggested the ability to watch the video file while it is being downloaded, in order to be able to judge the quality without wasting data by fetching the video twice (i.e. for viewing and for downloading).
The text was updated successfully, but these errors were encountered: