-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleting Files 3 times but they never get deleted... #1793
Comments
Could you make a video of the deletion pls |
Yes. I will.
…On Sat, Oct 6, 2018, 18:57 Christian Schabesberger ***@***.***> wrote:
Could you make a video of the deletion pls
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1793 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATbiwF0D9azeQAbasBD2RGQEgyA-_F9lks5uiNMEgaJpZM4XLaD1>
.
|
I can verify this. In order to really delete the file I have to hit back several times until I have completely exited the app. Otherwise, the fail is not really deleted and shows up again next time you go to downloads thanks! |
@nachoparker Exactly my friend :) , couldn't send a real pick of it , like should make a short gif. |
It's the snakbar, it seems not to work, so we should get rid of it. |
Help welcome :) |
IIRC this has been fixed in #1759. I used this branch for a couple of days and didn't notice the incorrect behavior any more. Unfortunately, I am testing a different PR now, so I can't check this again atm. |
I forgot to mention something else. If you delete the downloaded files externally, for instance, from VLC, this doesn't get detected by NewPipe and the files still show in the downloads section. |
Yea thats because there is an internal database that holds a reference to the files. One might have to write an updater that checks if the file still exists. |
fixed in #1759 |
thank you very much |
Maybe this is a phone problem but it was not before.
In the downloads section i press delete, all okay the song dissapears but then if i continue deleting songa, the deleted reappear again and actually they never get deleted from the memory :'(
The text was updated successfully, but these errors were encountered: