Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting Files 3 times but they never get deleted... #1793

Closed
goxr3plus opened this issue Oct 6, 2018 · 11 comments
Closed

Deleting Files 3 times but they never get deleted... #1793

goxr3plus opened this issue Oct 6, 2018 · 11 comments

Comments

@goxr3plus
Copy link

Maybe this is a phone problem but it was not before.

In the downloads section i press delete, all okay the song dissapears but then if i continue deleting songa, the deleted reappear again and actually they never get deleted from the memory :'(

@theScrabi
Copy link
Member

Could you make a video of the deletion pls

@goxr3plus
Copy link
Author

goxr3plus commented Oct 6, 2018 via email

@nachoparker
Copy link

I can verify this. In order to really delete the file I have to hit back several times until I have completely exited the app.

Otherwise, the fail is not really deleted and shows up again next time you go to downloads

thanks!

@goxr3plus
Copy link
Author

@nachoparker Exactly my friend :) , couldn't send a real pick of it , like should make a short gif.

@theScrabi
Copy link
Member

theScrabi commented Nov 13, 2018

It's the snakbar, it seems not to work, so we should get rid of it.

@theScrabi
Copy link
Member

theScrabi commented Nov 13, 2018

@TobiGr
Copy link
Contributor

TobiGr commented Nov 13, 2018

IIRC this has been fixed in #1759.

I used this branch for a couple of days and didn't notice the incorrect behavior any more.

Unfortunately, I am testing a different PR now, so I can't check this again atm.

@nachoparker
Copy link

I forgot to mention something else. If you delete the downloaded files externally, for instance, from VLC, this doesn't get detected by NewPipe and the files still show in the downloads section.

@theScrabi
Copy link
Member

Yea thats because there is an internal database that holds a reference to the files. One might have to write an updater that checks if the file still exists.

@TobiGr
Copy link
Contributor

TobiGr commented Dec 15, 2018

fixed in #1759

@TobiGr TobiGr closed this as completed Dec 15, 2018
@nachoparker
Copy link

thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants