"Delete Downloaded Files" does not work immediately before closing app

[ukanuk]

Checklist

• I am using the latest version - 0.21.1
• I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
• I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
• This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

1. Start and finish downloading at least one video.
2. Go to 'Menu>Downloads>Trashcan'.
3. In the 'Clear Download History' pop-up that has appeared, press on 'DELETE DOWNLOADED FILES'. Note the downloaded file(s) all disappear as expected, and there is an "Undo" pop-up at the bottom of the screen.
4. Immediately open the android app switcher / Recents view, and close NewPipe.
5. Reopen NewPipe, return to Menu>Downloads, and note the downloaded file(s) are all back.

Actual behaviour

Choosing 'DELETE DOWNLOADED FILES' immediately before closing the app does not in fact delete any files at all.

Expected behavior

Choosing 'DELETE DOWNLOADED FILES' immediately before closing the app DOES delete all the files. The Microsoft Edge app on Android has basically the same interface, including the Undo, but if I clean out my downloads immediately before closing the app, they stay deleted unlike NewPipe. I found #1793 (comment) which made me think of specifically waiting awhile before closing the app - and that does work around this issue. However I've been using the app for months, frequently annoyed that NewPipe usually wouldn't actually delete files when I asked it to, and it was only after coming and investigating Github issues that I realized the root cause is closing the app too quickly.

Screenshots/Screen recordings

Screen_Recording_20210424-135110_NewPipe_1.mp4

Logs

N/A

Device info

• Android version/Custom ROM version: Android 11 with April 1, 2021 security updates
• Device model: Samsung Galaxy S21 (same behavior happened on my old Galaxy S10e, but I did not think to submit a bug report until now).

[sauravrao637]

@ukanuk Thanks for helping improve NewPipe!
The files will not get deleted until "undo" button is not gone, it might be the case that user deleted all files but the app crashes/ or the device run of battery or some other thing leads to closing the app and then the user does not get chance to "undo" the delete (already feeling sorry for this user) ,so to be on safer side the files are deleted only after "undo" disappears giving the user a plenty of time to decide :)
The real issue will be if the undo button disappears and then closing the app but still files are not deleted , see if it's the case

[ukanuk]

If that's really the intended behavior, please change the UI so it no longer lies. An "Undo" pop-up with all the files deleted from view tells me all the files have been deleted. Instead, the pop-up should say something like "Deleting all in 5... 4... 3... 2... 1..." and have a "Cancel" button instead.

But even better than that would be implementing Trash, so that files are immediately marked for deletion but not actually deleted for a week.

Then an app crash doesn't require re-downloading any videos, but also people like me don't have to wait for a countdown timer (including with the existing Undo pop-up) when they've finished watching videos and just want to clean up their files and quit.

[sauravrao637]

So as you suggested we should have a cancel button and also we can have a button (say proceed) which onClick can skip the timer if someone don't have to wait , what do you think?

[ukanuk]

That would definitely be an improvement over the current behavior. The timeout and/or "Proceed" button still feel excessive to me (it's three clicks for trashcan+DELETE FILES+proceed), but I guess that's personal opinion.

After further thought, is it really useful for the first dialog to always force choosing between DELETE FILES and CLEAR HISTORY? I assume most people always want to do one or the other, so a dropdown could replace these two buttons and default to the previous behavior.

As a bonus, this change would eliminate those times I accidentally mis-click CLEAR HISTORY, and then to actually delete the files I have to open my phone file manager browse to the Newpipe folder, and manually delete the files there.

[makeyeu]

Have the same bug. In addition to that, i keep finding video files in the file browser that i deleted from newpipe long time ago but that were never actually deleted. I am not sure what was the reason, i think it's because when i delete a file manually i select another one and open the delete menu while the bottom pop up saying that i can undo is still showing.

[Feuerswut]

Close as not-planned.

This works as intended. Android has barely (if at all) a trash can system. Apps cant access it.

Undo does not actually un-delete anything. It simply cancels the impending deletion (which is not instant.)

E.g. Works as intended.

[opusforlife2]

@ukanuk ^