Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add measureElement on virtual item, when we can't relay on node.isConnected #737

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

piecyk
Copy link
Collaborator

@piecyk piecyk commented Jun 1, 2024

As we can relay on node.isConnected to attach the RO or read size, like in lit integration #718 we need to have another option to do. In this PR #737 let's add back the measureElement on virtual item and keep it stale via measureElementCache that has bound in scope index.

${ref(virtualRow.measureElement}

Copy link

nx-cloud bot commented Jun 1, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8b10dd2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@piecyk piecyk mentioned this pull request Jun 1, 2024
@piecyk piecyk requested a review from tannerlinsley June 1, 2024 11:23
@piecyk piecyk force-pushed the feat/measureElementCache branch 2 times, most recently from 8d3e14b to 37817a9 Compare June 2, 2024 13:57
@piecyk piecyk changed the title feat: add measureElementCache when we can't relay on node.isConnected feat: add measureElement on virtual item, when we can't relay on node.isConnected Jun 2, 2024
@piecyk piecyk force-pushed the feat/measureElementCache branch from 37817a9 to 311dc46 Compare June 2, 2024 14:20
@piecyk piecyk force-pushed the feat/measureElementCache branch 3 times, most recently from 06c92d1 to d49ef9f Compare June 21, 2024 10:11
@piecyk piecyk force-pushed the feat/measureElementCache branch from d49ef9f to 8b10dd2 Compare June 21, 2024 10:15
@piecyk piecyk merged commit afeb2fd into TanStack:main Jun 21, 2024
2 checks passed
@piecyk piecyk deleted the feat/measureElementCache branch June 21, 2024 13:15
@kkx64
Copy link

kkx64 commented Jul 29, 2024

@piecyk @tannerlinsley This is all good and well, but changing the type of VirtualItem to VirtualItem<T> in a minor release made our UI component builds randomly fail. Please be careful of these types of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants