-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lit integration #718
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fca0a99. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
@tannerlinsley @piecyk how can we move forward with this? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kadoshms awesome work 🥇 Had a quick look on adapter and added two comments, will check the examples letter but overall i think we can merge it soonish 👏
@kadoshms can you check why CI have failed? |
I think this should be fine now @piecyk |
hmm still something is off. |
Need to update the lock file with pnpm i |
I did @KevinVandy @piecyk (pnpm-lock is updated) |
@kadoshms reset lock and package.json to main and try to add it again, maybe something went off with 3-way merge |
@piecyk tried again |
@piecyk I'll try to open a new PR, maybe something is corrupt |
@piecyk I had an issue with corepack locally which is now resolved, now as the versions of pnpm locally and CI are the same, I think it should be ok now :) |
Lit is a growing library for building web-components with ease.
This PR introduces
@tanstack/lit-virtual
integration package for creating virtualized elements using Lit's Reactive ControllersI guess there's more room for improvement and testing, but it could definitely be a start for this.