Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lit integration #718

Merged
merged 19 commits into from
Jun 24, 2024
Merged

feat: lit integration #718

merged 19 commits into from
Jun 24, 2024

Conversation

kadoshms
Copy link
Contributor

Lit is a growing library for building web-components with ease.
This PR introduces @tanstack/lit-virtual integration package for creating virtualized elements using Lit's Reactive Controllers

I guess there's more room for improvement and testing, but it could definitely be a start for this.

Copy link

nx-cloud bot commented Apr 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fca0a99. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kadoshms
Copy link
Contributor Author

kadoshms commented May 1, 2024

@tannerlinsley @piecyk how can we move forward with this? :)

Copy link
Collaborator

@piecyk piecyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kadoshms awesome work 🥇 Had a quick look on adapter and added two comments, will check the examples letter but overall i think we can merge it soonish 👏

packages/lit-virtual/src/index.ts Outdated Show resolved Hide resolved
packages/lit-virtual/src/index.ts Outdated Show resolved Hide resolved
@kadoshms kadoshms requested a review from piecyk May 1, 2024 13:54
@piecyk
Copy link
Collaborator

piecyk commented Jun 24, 2024

@kadoshms can you check why CI have failed?

@kadoshms
Copy link
Contributor Author

I think this should be fine now @piecyk

@piecyk
Copy link
Collaborator

piecyk commented Jun 24, 2024

I think this should be fine now @piecyk

hmm still something is off.

@KevinVandy
Copy link
Member

Need to update the lock file with pnpm i

@kadoshms
Copy link
Contributor Author

kadoshms commented Jun 24, 2024

I did @KevinVandy @piecyk (pnpm-lock is updated)

@piecyk
Copy link
Collaborator

piecyk commented Jun 24, 2024

I did @KevinVandy @piecyk (pnpm-lock is updated)

@kadoshms reset lock and package.json to main and try to add it again, maybe something went off with 3-way merge

@kadoshms
Copy link
Contributor Author

@piecyk tried again

@kadoshms
Copy link
Contributor Author

@piecyk I'll try to open a new PR, maybe something is corrupt

@kadoshms
Copy link
Contributor Author

@piecyk I had an issue with corepack locally which is now resolved, now as the versions of pnpm locally and CI are the same, I think it should be ok now :)

@piecyk piecyk merged commit e02207d into TanStack:main Jun 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants