fix: replaceDeepEqual special case for non-plain arrays
#3669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1b4633a:
|
TkDodo
reviewed
Jun 5, 2022
|
@TkDodo your wishes have been granted |
TkDodo
approved these changes
Jun 6, 2022
Codecov Report
@@ Coverage Diff @@
## beta #3669 +/- ##
=======================================
Coverage 97.11% 97.11%
=======================================
Files 50 50
Lines 2389 2391 +2
Branches 705 706 +1
=======================================
+ Hits 2320 2322 +2
Misses 67 67
Partials 2 2
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 4.0.0-beta.22 🎉 The release is available on: Your semantic-release bot 📦🚀 |
GLabat
pushed a commit
to GLabat/react-query
that referenced
this pull request
Jun 27, 2022
…k-beta * 'beta' of https://github.com/TanStack/query: (140 commits) Fix Best of JS badge in README (TanStack#3695) Update config.json docs: adapter teasers docs: rewrite typescript docs tests: stabilize docs: Update graphql.md to fix link (TanStack#3683) docs: fix link typo in README.md (TanStack#3679) Update README.md update readme Update config.json Update index.js examples: vendor to platform directories docs: migrate to tanstack.com fix(persist): introduce in-house synchronous Storage interface (TanStack#3673) docs: restructure migration guide by importance of breaking changes fix: `replaceDeepEqual` special case for non-plain arrays (TanStack#3669) feat: make InfiniteQueryObserver's type more robust (TanStack#3571) fix(types): remove non-void constraint from queryFn result (TanStack#3666) fix(persist): remove environment check (TanStack#3658) fix(types): make sure queryClient.setQueriesData can return undefined from the updater (TanStack#3657) ...
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the
replaceDeepEqualfunction wasn't returning the intended value for objects that are non-plain arrays.E.g.
This data structure is used in libraries such as ethers and their contract
Resultvalue.I'm not sure if we should perform structural sharing on these values as they are not really "JSON-compatible" values as mentioned in the docs, so I added a change which just checks if the given array is a "plain array", and if it is not, it has changed.