fix pr comments

TanStack · Jun 5, 2022 · 1b4633a · 1b4633a
1 parent 2a0533b
commit 1b4633a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/core/tests/utils.test.tsx b/src/core/tests/utils.test.tsx
@@ -6,6 +6,7 @@ import {
   matchMutation,
   scheduleMicrotask,
   sleep,
+  isPlainArray,
 } from '../utils'
 import { Mutation } from '../mutation'
 import { createQueryClient } from '../../tests/utils'
@@ -56,6 +57,16 @@ describe('core/utils', () => {
     })
   })
 
+  describe('isPlainArray', () => {
+    it('should return `true` for plain arrays', () => {
+      expect(isPlainArray([1, 2])).toEqual(true)
+    })
+
+    it('should return `false` for non plain arrays', () => {
+      expect(isPlainArray(Object.assign([1, 2], { a: 'b' }))).toEqual(false)
+    })
+  })
+
   describe('partialDeepEqual', () => {
     it('should return `true` if a includes b', () => {
       const a = { a: { b: 'b' }, c: 'c', d: [{ d: 'd ' }] }

diff --git a/src/core/utils.ts b/src/core/utils.ts
@@ -355,8 +355,8 @@ export function shallowEqualObjects<T>(a: T, b: T): boolean {
   return true
 }
 
-export function isPlainArray(a: any) {
-  return Array.isArray(a) && a.length === Object.keys(a).length
+export function isPlainArray(value: unknown) {
+  return Array.isArray(value) && value.length === Object.keys(value).length
 }
 
 // Copied from: https://github.com/jonschlinkert/is-plain-object