[TASK] Remove functional test database configuration fallback #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolli42
approved these changes
Jan 31, 2024
Functional tests per nature speaks with a concrete database service, which can be configured using a et of `environment variables`. However, historically a fallback to `typo3conf/LocalConfiguration.php` or the root project has been used if no environment variable has been provided. This broke already in early TYPO3 v12 development cycle with the move towards configuration files outside of the public root folder in a composer based installation. Because of today usage of the testing-framework and the broader acceptance of ci/cd pipelines the environment variables are the recommended configuration option. Remove the broken fallback now. Resolves: #474 Releases: main
sbuerk
changed the title
lolli42
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional tests per nature speaks with a concrete database service,
which can be configured using a et of
environment variables.However, historically a fallback to
typo3conf/LocalConfiguration.phpor the root project has been used if no environment variable has been
provided.
This broke already in early TYPO3 v12 development cycle with the
move towards configuration files outside of the public root folder
in a composer based installation.
Because of today usage of the testing-framework and the broader
acceptance of ci/cd pipelines the environment variables are the
recommended configuration option. Remove the broken fallback now.
Resolves: #474
Releases: main