Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide what to do with outdated configuration path #474

Closed
alexanderschnitzler opened this issue May 30, 2023 · 1 comment · Fixed by #538
Closed

Decide what to do with outdated configuration path #474

alexanderschnitzler opened this issue May 30, 2023 · 1 comment · Fixed by #538

Comments

@alexanderschnitzler
Copy link
Contributor

Testbase does still fall back to typo3conf/LocalConfiguration.php although TYPO3 12 uses /config/system/settings.php nowadays. Should the fallback be dropped or at least be used after having tried /config/system/settings.php or should users simply switch to env variables?

Reference:

$originalConfigurationArray = require ORIGINAL_ROOT . 'typo3conf/LocalConfiguration.php';

@sbuerk
Copy link
Collaborator

sbuerk commented May 30, 2023

Personally, I would remove that "magic" fallback. But I guess we can't to that so easiely. So it should be fallback to v12 composer style variant with TF8 .. and TF7 based installed core version.

I'm more for "explicitly configure it". Some may have such a "file" for extension level testing to avoid using env variables .. but in a project it reuses the real instance settings.There may be reasons for that.

So not sure ... at least we should align to used core version default behaviour. Which makes it for TF7 more jumpy.

Multi DBMBS testing is easier with env variables, using the config file is a lazy excude why not doing multi database functional tests.

Had it on todo list to thing about it, but good to know that someone stumpled upon it ;) so I guess the simply remove it is maybe off the table.

sbuerk added a commit that referenced this issue Jan 31, 2024
Functional tests per nature speaks with a concrete atabase service,
which can be configured using a et of `environment variables`.
However, historically a fallback to `typo3conf/LocalConfiguration.php`
or the root project has been used if no environment variable has been
provided.

This broke already in early TYPO3 v12 development cycle with the
move towards configuration files outside of the public root folder
in a composer based installation.

Because of today usage of the testing-framework and the broader
acceptance of ci/cd pipelines the environment variable is the
recommended. Remove the broken fallback now.

Resolves: #474
Releases: main
sbuerk added a commit that referenced this issue Jan 31, 2024
Functional tests per nature speaks with a concrete atabase service,
which can be configured using a et of `environment variables`.
However, historically a fallback to `typo3conf/LocalConfiguration.php`
or the root project has been used if no environment variable has been
provided.

This broke already in early TYPO3 v12 development cycle with the
move towards configuration files outside of the public root folder
in a composer based installation.

Because of today usage of the testing-framework and the broader
acceptance of ci/cd pipelines the environment variables are the
recommended configuration option. Remove the broken fallback now.

Resolves: #474
Releases: main
sbuerk added a commit that referenced this issue Jan 31, 2024
Functional tests per nature speaks with a concrete database service,
which can be configured using a et of `environment variables`.
However, historically a fallback to `typo3conf/LocalConfiguration.php`
or the root project has been used if no environment variable has been
provided.

This broke already in early TYPO3 v12 development cycle with the
move towards configuration files outside of the public root folder
in a composer based installation.

Because of today usage of the testing-framework and the broader
acceptance of ci/cd pipelines the environment variables are the
recommended configuration option. Remove the broken fallback now.

Resolves: #474
Releases: main
sbuerk added a commit that referenced this issue Jan 31, 2024
Functional tests per nature speaks with a concrete database service,
which can be configured using a et of `environment variables`.
However, historically a fallback to `typo3conf/LocalConfiguration.php`
or the root project has been used if no environment variable has been
provided.

This broke already in early TYPO3 v12 development cycle with the
move towards configuration files outside of the public root folder
in a composer based installation.

Because of today usage of the testing-framework and the broader
acceptance of ci/cd pipelines the environment variables are the
recommended configuration option. Remove the broken fallback now.

Resolves: #474
Releases: main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants