Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #1117: Move more dependencies to latest or closer #1118

Merged
merged 9 commits into from
Jan 9, 2025

Conversation

tupaschoal
Copy link
Collaborator

Related issue

Helps #1117

Context / Background

Updates some of the packages that were outdated, but that also require code changes

What change is being introduced by this PR?

2e98fff - Just needed to rename the create_windows_installer.js to .cjs to work. @araujoarthur0 please check this is what was expected.
069a241 - Migrated electron-winstaller after fixing above.
1b2b9ea - Migrated mocha and converted the patch to the new version. Still need to check whether it is needed, but I think we can do it later.
411ada6 - Moved to the newly suported packager. Packaging for windows worked just fine.
b362970 - First moved husky to 9.0.11. Since 9.0.1 they simplified how to call it and the pre-commit file. See the "How to Migrate" section here.
92db47d - Moved husky to 9.1.7. Since 9.1.1 they allow commands on pre-commit to be called directly without npx. See the "What's new" section here
4179193 - Moved Sinon from 17.0.1 to 18.0.1. Didn't need changes in the code. Starting on 19 a lot of tests started timing out, so leaving that to later.
26123db - First moved eslint from 7.32.0 to 8.56.0, which didn't require any changes
104d28e - Upgraded eslint from 8.56.0 to 9.17.0. This required a lot of changes, first their format for eslint rules changed, so I used npx @eslint/migrate-config .eslintrc.json to migrate (and it touched a lot of files to remove useless comments too). Then it also required porting the --ext option from the package.json to the new file. Finally it started finding out these new errors about unused variables (hence removing the variable from the "catches") and most importantly, it complained the left-hand side of the following was invalid, so I changed it:
104d28e#diff-a78607de5ba60a651d090218cd6ad7a64ce478e985e6b1f68669b00ea8c35436L116

C:\GitHub\time-to-leave\js\validate-json.js
  116:9   error  Unexpected constant truthiness on the left-hand side of a `||` expression                        no-constant-binary-expression
  116:30  error  Unexpected constant binary expression. Compares constantly with the left-hand side of the `===`  no-constant-binary-expression
C:\GitHub\time-to-leave\js\validate-json.js
  116:31  error  Invalid typeof comparison value  valid-typeof

How will this be tested?

  • Did some manual tests and found nothing wrong
  • Ran npm test at every commit
  • Ran packager for windows

eslint.config.mjs Outdated Show resolved Hide resolved
@tupaschoal tupaschoal force-pushed the update-deps-code-change branch from 104d28e to c2d7a6e Compare January 9, 2025 10:41
Used npx @eslint/migrate-config .eslintrc.json to update the configuration.
See https://eslint.org/docs/latest/use/configure/migration-guide
@tupaschoal tupaschoal merged commit 5d041d6 into TTLApp:main Jan 9, 2025
3 checks passed
@tupaschoal tupaschoal deleted the update-deps-code-change branch January 9, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants