Part of #1117: Move more dependencies to latest or closer #1118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Helps #1117
Context / Background
Updates some of the packages that were outdated, but that also require code changes
What change is being introduced by this PR?
2e98fff - Just needed to rename the
create_windows_installer.js
to.cjs
to work. @araujoarthur0 please check this is what was expected.069a241 - Migrated
electron-winstaller
after fixing above.1b2b9ea - Migrated
mocha
and converted the patch to the new version. Still need to check whether it is needed, but I think we can do it later.411ada6 - Moved to the newly suported packager. Packaging for windows worked just fine.
b362970 - First moved husky to 9.0.11. Since 9.0.1 they simplified how to call it and the
pre-commit
file. See the "How to Migrate" section here.92db47d - Moved husky to 9.1.7. Since 9.1.1 they allow commands on
pre-commit
to be called directly withoutnpx
. See the "What's new" section here4179193 - Moved Sinon from 17.0.1 to 18.0.1. Didn't need changes in the code. Starting on 19 a lot of tests started timing out, so leaving that to later.
26123db - First moved eslint from 7.32.0 to 8.56.0, which didn't require any changes
104d28e - Upgraded eslint from 8.56.0 to 9.17.0. This required a lot of changes, first their format for eslint rules changed, so I used
npx @eslint/migrate-config .eslintrc.json
to migrate (and it touched a lot of files to remove useless comments too). Then it also required porting the--ext
option from thepackage.json
to the new file. Finally it started finding out these new errors about unused variables (hence removing the variable from the "catches") and most importantly, it complained the left-hand side of the following was invalid, so I changed it:104d28e#diff-a78607de5ba60a651d090218cd6ad7a64ce478e985e6b1f68669b00ea8c35436L116
How will this be tested?
npm test
at every commit