Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies that are lagging #1117

Open
7 of 10 tasks
tupaschoal opened this issue Jan 7, 2025 · 2 comments
Open
7 of 10 tasks

Update dependencies that are lagging #1117

tupaschoal opened this issue Jan 7, 2025 · 2 comments

Comments

@tupaschoal
Copy link
Collaborator

tupaschoal commented Jan 7, 2025

On #1116 I updated several dependencies that were outdated, but that didn't require any code change to update (i.e. no breaking changes with our usage). The dependencies that were not up-to-date and that were not upgraded are listed here with the reason for not updating, so we can follow-up:

  • electron-store from 8.1.0 to >=9
    Starting on electron-store 9, it requires electron 30. Since we are still on electron 28, it can't be upgraded
  • sinon from 17.0.1 to 18.0.1
  • sinon from 18.0.1 to 19
    Plenty of tests in our testsuite start to fail, needs investigation
  • mocha from 10.2.0 to 11.0.1
    We have a patch for mocha 10.2.0, need to investigate whether it will still be needed and, if not, also remove patch-package
  • husky from 8.0.3 to 9.1.7
    Starting on 9.1.1 husky allows running packages directly, so it would be good to improve the script along with the upgrade
  • eslint from 7.32.0 to 9.17.0
    Requires updating configs
  • electron-winstaller from 5.1.0 to 5.4.0
    Technically no breaking changes, but our only usage, npm run setup:win is currently broken, likely because of Migrating to Electron 28 #1054
  • electron-packager
    This is giving the warning

DEPRECATED ⚠️ - Please use @electron/packager moving forward. There is no API change, just a package name change

  • electron from 28.1.0 to 33.3.1
    It's always tricky/painful, so we need to move with care

Additionally, these are the warnings being printed upon running npm install:

npm WARN deprecated glob@8.1.0: Glob versions prior to v9 are no longer supported
npm WARN deprecated i18next-node-fs-backend@2.1.3: replaced by i18next-fs-backend
npm WARN deprecated asar@3.2.0: Please use @electron/asar moving forward.  There is no API change, just a package name change
npm WARN deprecated glob@7.2.0: Glob versions prior to v9 are no longer supported
npm WARN deprecated electron-osx-sign@0.5.0: Please use @electron/osx-sign moving forward. Be aware the API is slightly different
npm WARN deprecated electron-notarize@1.2.2: Please use @electron/notarize moving forward.  There is no API change, just a package name change

As far as I see, the only direct dependency we have there is i18next-node-fs-backend, the other are indirect dependencies

  • i18next-node-fs-backend to i18next-fs-backend
@araujoarthur0
Copy link
Collaborator

For the installer it might be good if we added some tests that invoke it to make sure it's not broken after changes

tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 8, 2025
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 8, 2025
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 8, 2025
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 8, 2025
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 8, 2025
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 8, 2025
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 8, 2025
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 8, 2025
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 8, 2025
Used npx @eslint/migrate-config .eslintrc.json to update the configuration.
See https://eslint.org/docs/latest/use/configure/migration-guide
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 9, 2025
Used npx @eslint/migrate-config .eslintrc.json to update the configuration.
See https://eslint.org/docs/latest/use/configure/migration-guide
tupaschoal added a commit that referenced this issue Jan 9, 2025
Part of #1117: Move more dependencies to latest or closer
@tupaschoal
Copy link
Collaborator Author

Merged #1118 and updated the issue header with everything that was done and everything still pending

tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 9, 2025
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 12, 2025
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 12, 2025
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 12, 2025
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 12, 2025
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 12, 2025
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 12, 2025
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 12, 2025
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 12, 2025
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 12, 2025
From electron-store 9 it requires node 20
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 12, 2025
tupaschoal added a commit that referenced this issue Jan 13, 2025
tupaschoal added a commit to tupaschoal/time-to-leave that referenced this issue Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants