task/tup-551 hide published text unless editing #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
reviewed
Dec 13, 2023
There was a problem hiding this comment.
Approved, but not merging until new Core-CMS build since TACC/Core-CMS#763. I'll notify when a new Core-CMS build is available.
wesleyboar
requested changes
Dec 13, 2023
There was a problem hiding this comment.
Please change this branch to use Core-CMS v4.3.0, which has the new setting.
I made a similar change on my open PR.
Important
If #394 gets merged first, then my request is moot.
wesleyboar
requested changes
Dec 13, 2023
There was a problem hiding this comment.
Ugh, I was too trigger happy with the CMS PR. This code won't achieve expectations, as-is.
- Designer expects "Published:" to not show (ever), because its superfluous (users know on News page what a date means).
- Editor expects "To be published" to show, so they can distinguish published from not yet published.
Whether user is editing or not depends on whether they clicked [Edit] button (i.e. whether URL has ?edit).
|
Closing this PR. Check TACC/Core-CMS#771 for updates. The PR above does what is necessary to meet the demands of this ticket. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes published verbiage when not editing.
Related
Changes
Simple. When not editing, the published verbiage is hidden. When editing the published verbiage appears.
Testing
TACC_BLOG_SHOW_PUB_TEXTvalue in thesettings_custom.pyfileUI
TACC_BLOG_SHOW_PUB_TEXT = False)TACC_BLOG_SHOW_PUB_TEXT = True)Notes