Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task/tup-551 Hide publish text from blog header #771

Merged
merged 3 commits into from
Dec 14, 2023
Merged

task/tup-551 Hide publish text from blog header #771

merged 3 commits into from
Dec 14, 2023

Conversation

R-Tomas-Gonzalez
Copy link
Collaborator

Overview

Hide publish text from blog header.

Related

Changes

  • Removing "published" text from blog headers
  • Adding in translations for To be published
  • Added a colon in after To be published

Testing

http://localhost:8000

  1. Add in a news section
  2. Publish a blog. Schedule a blog. And make one unpublished.
  3. Test published blogs have no "published" text or span markup before their dates
  4. Test when editing that "To be published" and "Unpublished" text still appears

UI

editing
Screenshot 2023-12-14 at 12 28 59 PM
not editing
Screenshot 2023-12-14 at 12 29 25 PM

@R-Tomas-Gonzalez R-Tomas-Gonzalez added priority ━ Medium priority effort XS Extra small effort task (~¼ a week) — does not include review time labels Dec 14, 2023
@R-Tomas-Gonzalez R-Tomas-Gonzalez self-assigned this Dec 14, 2023
@R-Tomas-Gonzalez R-Tomas-Gonzalez mentioned this pull request Dec 14, 2023
Closed
@wesleyboar wesleyboar merged commit 1ad7be8 into main Dec 14, 2023
@wesleyboar wesleyboar deleted the task/tup-551-hide-publish-text-2 branch December 14, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleyboar wesleyboar wesleyboar approved these changes

Assignees

@R-Tomas-Gonzalez R-Tomas-Gonzalez

Labels
effort XS Extra small effort task (~¼ a week) — does not include review time priority ━ Medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@R-Tomas-Gonzalez @wesleyboar