Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add+use core-styles.wysiwyg.css not copied code #618

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 31, 2023

Overview

Create a core-styles.wysiwyg.css to load that code from installed Core-Styles (rather than rely on copied code).

Related

Changes

  • added core-styles.wysiwyg.css
  • added .../ckeditor/contents.original.css to have original contents of .../ckeditor/contents.css
  • changed .../ckeditor/contents.css to load the two new stylesheets

Testing

  1. Create/Edit a Text plugin.
  2. Style a block of text as "Island" (like in #595 video).
  3. Verify island is styled inside Text editor.

UI

618.mov

Create a `core-styles.wysiwyg.css` to load that code from installed Core-Styles (rather than rely on copied code).
@wesleyboar wesleyboar changed the title fix: add+use core-styles.wysiwyg.css, no copy code fix: add+use core-styles.wysiwyg.css not copied code Apr 5, 2023
@wesleyboar wesleyboar force-pushed the task/core-styles-wysiwyg-css branch from b5e8440 to 65c5350 Compare April 5, 2023 23:09
@wesleyboar wesleyboar changed the base branch from dev/tup-cms to main April 5, 2023 23:15
@wesleyboar wesleyboar changed the base branch from main to dev/tup-cms April 5, 2023 23:16
@wesleyboar wesleyboar marked this pull request as ready for review April 5, 2023 23:16
@wesleyboar wesleyboar merged commit 44cc9a2 into dev/tup-cms Apr 5, 2023
@wesleyboar wesleyboar deleted the task/core-styles-wysiwyg-css branch April 5, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant