Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): wysiwyg customization #595

Merged
merged 6 commits into from
Mar 21, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Feb 7, 2023

Overview

Make the WYSIWYG editor fit TACC website usage.

Related

Changes

  • fixed wysiwyg to use <mark> not <span>
  • removed unnecessary elements from wysiwyg editor
  • added "Island" (aside.c-island) to wysiwyg editor

Testing & UI

c-island.in.djangocms_news.mov

The island styling in actual article (not text editor) was tested in dev/tup-cms branch. Not yet available in main.1

Footnotes

  1. Main is using an older version of Core-Styles. It will render in the text editor, because the text editor uses a file with isolated and minified core-styles 2.6.1 c-island.css.

wesleyboar and others added 5 commits December 9, 2022 18:35
This tells Text plugin to allow inline elements outside `<p>` tags.

Source: https://stackoverflow.com/a/24701004/11817077
This tells Text plugin to:
- Make "Marker" create <mark> not <span class="marker">.
- Prepend "⚠️" to "Block Styles" because they use inline styles.

Problems:
1. The <mark> tag is escaped, it becomes "<mark>" not HTML.
2. There is so much default code to reproduce. Maintenance worth it?
@wesleyboar wesleyboar marked this pull request as ready for review March 21, 2023 23:45
@wesleyboar wesleyboar closed this Mar 21, 2023
@wesleyboar wesleyboar reopened this Mar 21, 2023
@wesleyboar wesleyboar merged commit 5a5eeef into main Mar 21, 2023
@wesleyboar wesleyboar deleted the task/wysiwyg-editor-customization--continued branch March 21, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant