Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto-responsive video embed #590

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

wesleyboar
Copy link
Member

Overview

Add choice for template that lets video plugin use automatic height for responsive media.

Related

Changes

  • add new djangocms_video template
  • add styles to undo hard ratio responsiveness for a non-specific responsive embed.

Testing

  1. Add a Video plugin instance.
  2. Set the URL to https://w.soundcloud.com/player/?url=https%3A//api.soundcloud.com/tracks/1242255460.
  3. Save the instance.
  4. Verify the embed takes up available horizontal space in container.
  5. Verify the height is nor more nor less than the height the embed needs.

UI

responsive-automatic

@wesleyboar wesleyboar changed the base branch from main to dev/tup-cms February 3, 2023 22:39
@wesleyboar wesleyboar merged commit c372d66 into dev/tup-cms Feb 3, 2023
@wesleyboar wesleyboar deleted the task/auto-responsive-vdeo-embed branch February 3, 2023 22:40
@wesleyboar wesleyboar changed the title Task/auto responsive vdeo embed feat: auto-responsive video embed Feb 3, 2023
wesleyboar added a commit to TACC/tup-ui that referenced this pull request Feb 3, 2023
wesleyboar added a commit that referenced this pull request Nov 13, 2023
Implement the #568 fix from PR #590 until we update our ckeditor to v5.

This will save H.P. (main CMS admin/designer) so many tiny bits of time.
wesleyboar added a commit that referenced this pull request Nov 13, 2023
* fix(django): implement djangocms-text-ckeditor#568

Implement the #568 fix from PR #590 until we update our ckeditor to v5.

This will save H.P. (main CMS admin/designer) so many tiny bits of time.

* fix(django): working remote url for remote css

Fixes: #540

* fix: delete unrelated file added during merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant