Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement django-cms/djangocms-text-ckeditor#568 #540

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Aug 16, 2022

Overview

Implement the Issue #568 fix from PR #590 until we update our ckeditor to v5.

This will save H.P. (main CMS admin/designer) so many tiny bits of time, because she must resize a modal every time she wants to edit source, which is many times everyday.

Related

N/A

Changes

  • extend djangocms-text-ckeditor css
  • duplicate the relevant fix

Testing

  1. Be logged into CMS as admin.
  2. Add a Text plugin instance.
  3. Edit Text plugin instance content as source (the "[<>] Source" button, top-right).
  4. Confirm the textarea (in which to edit source markup) fills available vertical space.

UI

Screen Shot 2022-08-15 at 19 25 03

I am using Dark Reader browser extension; that is why it is dark gray, not white.

Implement the #568 fix from PR #590 until we update our ckeditor to v5.

This will save H.P. (main CMS admin/designer) so many tiny bits of time.
@wesleyboar wesleyboar merged commit cd2d6d9 into main Aug 16, 2022
@wesleyboar wesleyboar deleted the bugfix/djangocms-text-ckeditor-568-from-590 branch August 16, 2022 00:26
wesleyboar added a commit that referenced this pull request Aug 16, 2022
wesleyboar added a commit that referenced this pull request Aug 16, 2022
* fix(django): implement djangocms-text-ckeditor#568

Implement the #568 fix from PR #590 until we update our ckeditor to v5.

This will save H.P. (main CMS admin/designer) so many tiny bits of time.

* fix(django): working remote url for remote css

Fixes: #540

* fix: delete unrelated file added during merge
@wesleyboar wesleyboar changed the title fix(django): implement djangocms-text-ckeditor#568 fix(django): implement django-cms/djangocms-text-ckeditor#568 Dec 9, 2022
@wesleyboar wesleyboar changed the title fix(django): implement django-cms/djangocms-text-ckeditor#568 fix: implement django-cms/djangocms-text-ckeditor#568 Dec 9, 2022
wesleyboar added a commit that referenced this pull request Dec 9, 2022
wesleyboar added a commit that referenced this pull request Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant