Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: Remove Old ProTX Templates from Its Settings #470

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Hotfix: Remove Old ProTX Templates from Its Settings #470

merged 2 commits into from
Mar 23, 2022

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 23, 2022 •
edited
Loading

Overview

  • Delete CMS_TEMPLATES entries that do not exist (ProTX, ECEP).
  • Delete CMS_TEMPLATES entries that are commented out (LCCF, TAPIS).

Related

Requires

Testing

  1. ProTX (Pre-Prod) pages that use old templates will load after I set correct template (which was not possible in v3.5.1):

Notes

Build, Deploy

@wesleyboar wesleyboar changed the title fix(protx, ecep, ...): drop old CMS_TEMPLATE's Hotfix: Remove Old ProTX Templates from Its Settings Mar 23, 2022
@wesleyboar wesleyboar mentioned this pull request Mar 23, 2022
Merged
@wesleyboar wesleyboar requested review from duckonomy and taoteg and removed request for taoteg and duckonomy March 23, 2022 20:52
@wesleyboar
Copy link
Member Author

wesleyboar commented Mar 23, 2022 •
edited
Loading

It's end-of-day, and the problem and fix are exactly what I thought. Fix works. I'm pushing this in so ProTX can deploy with the others.

@wesleyboar wesleyboar merged commit bef4667 into main Mar 23, 2022
@wesleyboar wesleyboar deleted the hotfix/protx-and-more-cms-templates branch March 23, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar