Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick: Remove Cruft & Prevent Duplicate README's #123

Merged
merged 3 commits into from
Mar 18, 2022

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 9, 2022

Overview

Prevent duplicate documentation…

…by taking it out of example-cms.

Remove duplicate documentation…

…which came from cloning example-cms.

Remove duplicate unused example CSS…

…which came from cloning example-cms.

But now it instead documents which directory structure to clone (rather than cloning it with sample content).

Related

  • None

Changes

  • Move example-cms README's to README-cms.
  • Change /README.md to format of those from related repos.
  • Remove duplicate README's.
  • Remove superfluous comments.
  • Replace site.css's (and imports and template inclusion) with placeholder.css's.

Testing

We could build every portal [portals with changes beyond .md files]—

  • ecep-cms
  • example-cms
  • neuronex-cms
  • protx-cms
  • tup-cms

—but I do not believe these are breaking changes.

@wesleyboar wesleyboar requested review from taoteg and duckonomy March 9, 2022 21:56
Copy link
Collaborator

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I love removing cruft.

@wesleyboar wesleyboar merged commit ea0a066 into main Mar 18, 2022
@wesleyboar wesleyboar deleted the quick/cleanup-resources branch March 18, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants